Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-4798

Sleeps and synchronisation improvements for tests

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.94.0
    • Fix Version/s: 0.94.0
    • Component/s: master, regionserver, test
    • Labels:
      None
    • Environment:

      all

    • Release Note:
      last try on the same patch, but I think it's ok to commit it.

      Description

      Multiple small changes:

      @commiters: Removing some sleeps made visible a bug on JVMClusterUtil#HMaster#waitForServerOnline, so I had to add a synchro point. You may want to review this.

      JVMClusterUtil#HMaster#waitForServerOnline: removed, the condition was never met (test on "!c && !!c"). Added a new synchronization point.

      AssignementManager#waitForAssignment: add a timeout on the wait => not stuck if the notification is received before the wait.

      HMaster#loop: use a notification instead of a 1s sleep

      HRegionServer#waitForServerOnline: new method used by JVMClusterUtil#waitForServerOnline() to replace a 1s sleep by a notification

      HRegionServer#getMaster() 1s sleeps replaced by one 0,1s sleep and one 0,2s sleep

      HRegionServer#stop: use a notification on sleeper to lower shutdown by 0,5s

      ZooKeeperNodeTracker#start: replace a recursive call by a loop

      ZooKeeperNodeTracker#blockUntilAvailable: add a timeout on the wait => not stuck if the notification is received before the wait.

      HBaseTestingUtility#expireSession: use a timeout of 1s instead of 5s

      TestZooKeeper#testClientSessionExpired: use a timeout of 1s instead of 5s, with the change on HBaseTestingUtility we are 60s faster

      TestRegionRebalancing#waitForAllRegionsAssigned: use a sleep of 0,2s instead of 1s

      TestRestartCluster#testClusterRestart: send all the table creation together, then check creation, should be faster

      TestHLog: shutdown the whole cluster instead of DFS only (more standard)

      JVMClusterUtil#startup: lower the sleep from 1s to 0,1s

      HConnectionManager#close: Zookeeper name in debug message from HConnectionManager after connection close was always null because it was set to null in the delete.

        Attachments

        1. 4798_trunk_all.v10.patch
          18 kB
          Nicolas Liochon
        2. 4798_trunk_all.v10.patch
          18 kB
          Nicolas Liochon
        3. 4798_trunk_all.v10.patch
          18 kB
          Nicolas Liochon
        4. 4798_trunk_all.v10.patch
          18 kB
          Nicolas Liochon
        5. 4798_trunk_all.v10.patch
          18 kB
          Nicolas Liochon
        6. 4798_trunk_all.v2.patch
          17 kB
          Nicolas Liochon
        7. 4798_trunk_all.v5.patch
          21 kB
          Nicolas Liochon
        8. 4798_trunk_all.v6.patch
          21 kB
          Nicolas Liochon
        9. 4798_trunk_all.v7.patch
          23 kB
          Nicolas Liochon

        Issue Links

          Activity

            People

            • Assignee:
              nkeywal Nicolas Liochon
              Reporter:
              nkeywal Nicolas Liochon

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment