Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-4779

TestHTablePool, TestScanWithBloomError, TestRegionSplitCalculator are not tagged and TestPoolMap should not use TestSuite

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 0.94.0
    • Fix Version/s: 0.94.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      All tests must be tagged now.
      TestSuite is deprecated since JUnit 4.4, and does not works well with JUnit categories & surefire.

      1. 4779_trunk_all.patch
        7 kB
        Nicolas Liochon
      2. 4779_trunk_all.v2.patch
        7 kB
        Nicolas Liochon

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          Integrated in HBase-TRUNK #2433 (See https://builds.apache.org/job/HBase-TRUNK/2433/)
          HBASE-4779 TestHTablePool, TestScanWithBloomError, TestRegionSplitCalculator are
          not tagged and TestPoolMap should not use TestSuite (N Keywal)

          tedyu :
          Files :

          • /hbase/trunk/CHANGES.txt
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestServerName.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestHTablePool.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestPoolMap.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java
          Show
          hudson Hudson added a comment - Integrated in HBase-TRUNK #2433 (See https://builds.apache.org/job/HBase-TRUNK/2433/ ) HBASE-4779 TestHTablePool, TestScanWithBloomError, TestRegionSplitCalculator are not tagged and TestPoolMap should not use TestSuite (N Keywal) tedyu : Files : /hbase/trunk/CHANGES.txt /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestServerName.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestHTablePool.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestStore.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestPoolMap.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Thanks for the patch, N.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Thanks for the patch, N.
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Integrated to TRUNK.

          Show
          yuzhihong@gmail.com Ted Yu added a comment - Integrated to TRUNK.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12503530/4779_trunk_all.v2.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 18 new or modified tests.

          -1 javadoc. The javadoc tool appears to have generated -163 warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          -1 findbugs. The patch appears to introduce 50 new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          +1 core tests. The patch passed unit tests in .

          Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/240//testReport/
          Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/240//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/240//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12503530/4779_trunk_all.v2.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 18 new or modified tests. -1 javadoc. The javadoc tool appears to have generated -163 warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. -1 findbugs. The patch appears to introduce 50 new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed unit tests in . Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/240//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/240//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/240//console This message is automatically generated.
          Hide
          nkeywal Nicolas Liochon added a comment -

          refresh trunk. Added ServerName which was without category on trunk

          Show
          nkeywal Nicolas Liochon added a comment - refresh trunk. Added ServerName which was without category on trunk
          Hide
          yuzhihong@gmail.com Ted Yu added a comment -

          Please fix the following:

          Hunk #6 FAILED at 62.
          3 out of 6 hunks FAILED -- saving rejects to file src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java.rej
          
          Show
          yuzhihong@gmail.com Ted Yu added a comment - Please fix the following: Hunk #6 FAILED at 62. 3 out of 6 hunks FAILED -- saving rejects to file src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java.rej
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12503495/4779_trunk_all.patch
          against trunk revision .

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 12 new or modified tests.

          -1 patch. The patch command could not apply the patch.

          Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/238//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12503495/4779_trunk_all.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/238//console This message is automatically generated.

            People

            • Assignee:
              nkeywal Nicolas Liochon
              Reporter:
              nkeywal Nicolas Liochon
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development