Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.92.0, 0.94.0
    • Fix Version/s: 0.92.0, 0.94.0
    • Component/s: None
    • Labels:
      None

      Description

      When using null as a value for a mutation, HBasse thrift client failed and threw an error. We should instad check for a null byte buffer.

      1. HBASE-4679.patch
        3 kB
        Nicolas Spiegelberg

        Activity

        Hide
        hudson Hudson added a comment -

        Integrated in HBase-0.92 #90 (See https://builds.apache.org/job/HBase-0.92/90/)
        HBASE-4679 Thrift null mutation error

        nspiegelberg :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java
        • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        Show
        hudson Hudson added a comment - Integrated in HBase-0.92 #90 (See https://builds.apache.org/job/HBase-0.92/90/ ) HBASE-4679 Thrift null mutation error nspiegelberg : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        Hide
        hudson Hudson added a comment -

        Integrated in HBase-TRUNK #2377 (See https://builds.apache.org/job/HBase-TRUNK/2377/)
        HBASE-4679 Thrift null mutation error

        nspiegelberg :
        Files :

        • /hbase/trunk/CHANGES.txt
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        Show
        hudson Hudson added a comment - Integrated in HBase-TRUNK #2377 (See https://builds.apache.org/job/HBase-TRUNK/2377/ ) HBASE-4679 Thrift null mutation error nspiegelberg : Files : /hbase/trunk/CHANGES.txt /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
        Hide
        stack stack added a comment -

        @Nicolas Hadoop patch build does svn only so do a --no-prefix before attaching. Otherwise +1 on patch (you'll need to do thrift gen to commit – Jon is going to commit another thrift patch so maybe just the one of you should do it rather than have you both doing thrift gen'ing).

        Show
        stack stack added a comment - @Nicolas Hadoop patch build does svn only so do a --no-prefix before attaching. Otherwise +1 on patch (you'll need to do thrift gen to commit – Jon is going to commit another thrift patch so maybe just the one of you should do it rather than have you both doing thrift gen'ing).
        Hide
        nspiegelberg Nicolas Spiegelberg added a comment -

        internally reviewed by: karthik.ranga & dhruba. Will commit at the end of today unless people have questions.

        Show
        nspiegelberg Nicolas Spiegelberg added a comment - internally reviewed by: karthik.ranga & dhruba. Will commit at the end of today unless people have questions.
        Hide
        nspiegelberg Nicolas Spiegelberg added a comment -

        does Hadoop QA not understand files made by GIT? This applied cleanly to 92 & trunk as of rev 1188410.

        Show
        nspiegelberg Nicolas Spiegelberg added a comment - does Hadoop QA not understand files made by GIT? This applied cleanly to 92 & trunk as of rev 1188410.
        Hide
        hadoopqa Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12500808/HBASE-4679.patch
        against trunk revision .

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 3 new or modified tests.

        -1 patch. The patch command could not apply the patch.

        Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/67//console

        This message is automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12500808/HBASE-4679.patch against trunk revision . +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/67//console This message is automatically generated.

          People

          • Assignee:
            nspiegelberg Nicolas Spiegelberg
            Reporter:
            nspiegelberg Nicolas Spiegelberg
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development