HBase
  1. HBase
  2. HBASE-4673

NPE in HFileReaderV2.close during major compaction when hfile.block.cache.size is set to 0

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.94.0
    • Fix Version/s: 0.92.0, 0.94.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      On a test system got this exception when hfile.block.cache.size is set to 0:

      java.lang.NullPointerException
      at org.apache.hadoop.hbase.io.hfile.HFileReaderV2.close(HFileReaderV2.java:321)
      at org.apache.hadoop.hbase.regionserver.StoreFile$Reader.close(StoreFile.java:1065)
      at org.apache.hadoop.hbase.regionserver.StoreFile.closeReader(StoreFile.java:539)
      at org.apache.hadoop.hbase.regionserver.StoreFile.deleteReader(StoreFile.java:549)
      at org.apache.hadoop.hbase.regionserver.Store.completeCompaction(Store.java:1314)
      at org.apache.hadoop.hbase.regionserver.Store.compact(Store.java:686)
      at org.apache.hadoop.hbase.regionserver.HRegion.compact(HRegion.java:1016)
      at org.apache.hadoop.hbase.regionserver.compactions.CompactionRequest.run(CompactionRequest.java:178)
      at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
      at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
      at java.lang.Thread.run(Thread.java:619)

      Minor issue as nobody in their right mind with have hfile.block.cache.size=0

      Looks like this is due to HBASE-4422

      1. 4673.txt
        0.7 kB
        Lars Hofhansl

        Activity

        Hide
        Lars Hofhansl added a comment -

        One liner...

        Show
        Lars Hofhansl added a comment - One liner...
        Hide
        stack added a comment -

        +1

        Show
        stack added a comment - +1
        Hide
        Todd Lipcon added a comment -

        This should go in 0.92 also, right? (HFv2 is in 92)

        Show
        Todd Lipcon added a comment - This should go in 0.92 also, right? (HFv2 is in 92)
        Hide
        Lars Hofhansl added a comment -

        You are right. Didn't realized that jgray had checked the cache config code in 0.92 as well.

        Show
        Lars Hofhansl added a comment - You are right. Didn't realized that jgray had checked the cache config code in 0.92 as well.
        Hide
        Lars Hofhansl added a comment -

        Done

        Show
        Lars Hofhansl added a comment - Done
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #83 (See https://builds.apache.org/job/HBase-0.92/83/)
        HBASE-4673 NPE in HFileReaderV2.close during major compaction when hfile.block.cache.size is set to 0

        larsh :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
        Show
        Hudson added a comment - Integrated in HBase-0.92 #83 (See https://builds.apache.org/job/HBase-0.92/83/ ) HBASE-4673 NPE in HFileReaderV2.close during major compaction when hfile.block.cache.size is set to 0 larsh : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2372 (See https://builds.apache.org/job/HBase-TRUNK/2372/)
        HBASE-4673 NPE in HFileReaderV2.close during major compaction when hfile.block.cache.size is set to 0

        larsh :
        Files :

        • /hbase/trunk/CHANGES.txt
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2372 (See https://builds.apache.org/job/HBase-TRUNK/2372/ ) HBASE-4673 NPE in HFileReaderV2.close during major compaction when hfile.block.cache.size is set to 0 larsh : Files : /hbase/trunk/CHANGES.txt /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java

          People

          • Assignee:
            Lars Hofhansl
            Reporter:
            Lars Hofhansl
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development