HBase
  1. HBase
  2. HBASE-2856 TestAcidGuarantee broken on trunk
  3. HBASE-4594

Ensure that KV's newer than the oldest-living-scanner is not accounted for the maxVersions during flush/compaction.

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.94.0
    • Component/s: None
    • Labels:
      None
    1. 4594-v1.diff
      34 kB
      Amitanand Aiyer
    2. 4594-v2.diff
      31 kB
      Amitanand Aiyer

      Activity

      Hide
      Hudson added a comment -

      Integrated in HBase-TRUNK #2454 (See https://builds.apache.org/job/HBase-TRUNK/2454/)
      HBASE-4594 Fix maxVersions when scanning a file with a TS > read point

      nspiegelberg :
      Files :

      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ColumnTracker.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ExplicitColumnTracker.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ReadWriteConsistencyControl.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanWildcardColumnTracker.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java
      • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
      • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java
      • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java
      • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWildcardColumnTracker.java
      Show
      Hudson added a comment - Integrated in HBase-TRUNK #2454 (See https://builds.apache.org/job/HBase-TRUNK/2454/ ) HBASE-4594 Fix maxVersions when scanning a file with a TS > read point nspiegelberg : Files : /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderV2.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileWriterV2.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ColumnTracker.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ExplicitColumnTracker.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ReadWriteConsistencyControl.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanQueryMatcher.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/ScanWildcardColumnTracker.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/Store.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileScanner.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestExplicitColumnTracker.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestFSErrorsExposed.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWildcardColumnTracker.java
      Hide
      Nicolas Spiegelberg added a comment -

      note: this was part of the hbase-2856 review board. broken out for clarity and to map the JIRA with the changes.

      Show
      Nicolas Spiegelberg added a comment - note: this was part of the hbase-2856 review board. broken out for clarity and to map the JIRA with the changes.
      Hide
      Nicolas Spiegelberg added a comment -

      +1 lgtm. went over this in an internal review with kannan

      Show
      Nicolas Spiegelberg added a comment - +1 lgtm. went over this in an internal review with kannan
      Hide
      Amitanand Aiyer added a comment -

      sorry about that. v2 should be fixed with the latest version.

      Show
      Amitanand Aiyer added a comment - sorry about that. v2 should be fixed with the latest version.
      Hide
      stack added a comment -

      AA, your pom.xml is out of date – you are taking us back a version for the surefire plugin. I don't think you intend that.

      Show
      stack added a comment - AA, your pom.xml is out of date – you are taking us back a version for the surefire plugin. I don't think you intend that.

        People

        • Assignee:
          Amitanand Aiyer
          Reporter:
          Amitanand Aiyer
        • Votes:
          0 Vote for this issue
          Watchers:
          0 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development