HBase
  1. HBase
  2. HBASE-4568

Make zk dump jsp response more quickly

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.92.0, 0.94.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      1) For each zk dump, currently hbase will create a zk client instance every time.
      This is quite slow when any machines in the quorum is dead. Because it will connect to each machine in the zk quorum again.

      <code>
      HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);
      Configuration conf = master.getConfiguration();
      HBaseAdmin hbadmin = new HBaseAdmin(conf);
      HConnection connection = hbadmin.getConnection();
      ZooKeeperWatcher watcher = connection.getZooKeeperWatcher();
      </code>

      So we can simplify this:
      <code>
      HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);
      ZooKeeperWatcher watcher = master.getZooKeeperWatcher();
      </code>

      2) Also when hbase call getServerStats() for each machine in the zk quorum, it hard coded the default time out as 1 min.
      It would be nice to make this configurable and set it to a low time out.

      When hbase tries to connect to each machine in the zk quorum, it will create the socket, and then set the socket time out, and read it with this time out.
      It means hbase will create a socket and connect to the zk server with 0 time out at first, which will take a long time.
      Because a timeout of zero is interpreted as an infinite timeout. The connection will then block until established or an error occurs.

      3) The recoverable zookeeper should be real exponentially backoff when there is connection loss exception, which will give hbase much longer time window to recover from zk machine failures.

      1. HBASE-4568.patch
        11 kB
        Nicolas Spiegelberg

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2325 (See https://builds.apache.org/job/HBase-TRUNK/2325/)
        HBASE-4568 Make zk dump jsp response faster

        nspiegelberg :
        Files :

        • /hbase/trunk/CHANGES.txt
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        • /hbase/trunk/src/main/resources/hbase-webapps/master/zk.jsp
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2325 (See https://builds.apache.org/job/HBase-TRUNK/2325/ ) HBASE-4568 Make zk dump jsp response faster nspiegelberg : Files : /hbase/trunk/CHANGES.txt /hbase/trunk/src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java /hbase/trunk/src/main/resources/hbase-webapps/master/zk.jsp
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #64 (See https://builds.apache.org/job/HBase-0.92/64/)
        HBASE-4568 Make zk dump jsp response faster

        nspiegelberg :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
        • /hbase/branches/0.92/src/main/resources/hbase-webapps/master/zk.jsp
        Show
        Hudson added a comment - Integrated in HBase-0.92 #64 (See https://builds.apache.org/job/HBase-0.92/64/ ) HBASE-4568 Make zk dump jsp response faster nspiegelberg : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java /hbase/branches/0.92/src/main/resources/hbase-webapps/master/zk.jsp
        Hide
        Nicolas Spiegelberg added a comment -

        please remember to attach the patch to JIRA in addition to posting to Review Board. Hopefully, we'll have RB or Phabricator automatically do this for us in the future.

        Show
        Nicolas Spiegelberg added a comment - please remember to attach the patch to JIRA in addition to posting to Review Board. Hopefully, we'll have RB or Phabricator automatically do this for us in the future.
        Hide
        Nicolas Spiegelberg added a comment -

        +1. awesome job!

        Show
        Nicolas Spiegelberg added a comment - +1. awesome job!
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2385/#review2574
        -----------------------------------------------------------

        +1. Changes look good Liyin.

        • Kannan

        On 2011-10-13 22:36:46, Liyin wrote:

        -----------------------------------------------------------

        This is an automatically generated e-mail. To reply, visit:

        https://reviews.apache.org/r/2385/

        -----------------------------------------------------------

        (Updated 2011-10-13 22:36:46)

        Review request for hbase, Dhruba Borthakur, Michael Stack, Jonathan Gray, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg.

        Summary

        -------

        1) For each zk dump, currently hbase will create a zk client instance every time.

        This is quite slow when any machines in the quorum is dead. Because it will connect to each machine in the zk quorum again.

        <code>

        HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);

        Configuration conf = master.getConfiguration();

        HBaseAdmin hbadmin = new HBaseAdmin(conf);

        HConnection connection = hbadmin.getConnection();

        ZooKeeperWatcher watcher = connection.getZooKeeperWatcher();

        </code>

        So we can simplify this:

        <code>

        HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);

        ZooKeeperWatcher watcher = master.getZooKeeperWatcher();

        </code>

        2) Also when hbase call getServerStats() for each machine in the zk quorum, it hard coded the default time out as 1 min.

        It would be nice to make this configurable and set it to a low time out.

        When hbase tries to connect to each machine in the zk quorum, it will create the socket, and then set the socket time out, and read it with this time out.

        It means hbase will create a socket and connect to the zk server with 0 time out at first, which will take a long time.

        Because a timeout of zero is interpreted as an infinite timeout. The connection will then block until established or an error occurs.

        3) The recoverable zookeeper should be real exponentially backoff when there is connection loss exception, which will give hbase much longer time window to recover from zk machine failures.

        This addresses bug HBASE-4568.

        https://issues.apache.org/jira/browse/HBASE-4568

        Diffs

        -----

        src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java 61ea552

        src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java b8c4f61

        src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 699a5f5

        src/main/resources/hbase-webapps/master/zk.jsp b31d94c

        Diff: https://reviews.apache.org/r/2385/diff

        Testing

        -------

        Running all the unit tests

        Thanks,

        Liyin

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2385/#review2574 ----------------------------------------------------------- +1. Changes look good Liyin. Kannan On 2011-10-13 22:36:46, Liyin wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2385/ ----------------------------------------------------------- (Updated 2011-10-13 22:36:46) Review request for hbase, Dhruba Borthakur, Michael Stack, Jonathan Gray, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg. Summary ------- 1) For each zk dump, currently hbase will create a zk client instance every time. This is quite slow when any machines in the quorum is dead. Because it will connect to each machine in the zk quorum again. <code> HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER); Configuration conf = master.getConfiguration(); HBaseAdmin hbadmin = new HBaseAdmin(conf); HConnection connection = hbadmin.getConnection(); ZooKeeperWatcher watcher = connection.getZooKeeperWatcher(); </code> So we can simplify this: <code> HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER); ZooKeeperWatcher watcher = master.getZooKeeperWatcher(); </code> 2) Also when hbase call getServerStats() for each machine in the zk quorum, it hard coded the default time out as 1 min. It would be nice to make this configurable and set it to a low time out. When hbase tries to connect to each machine in the zk quorum, it will create the socket, and then set the socket time out, and read it with this time out. It means hbase will create a socket and connect to the zk server with 0 time out at first, which will take a long time. Because a timeout of zero is interpreted as an infinite timeout. The connection will then block until established or an error occurs. 3) The recoverable zookeeper should be real exponentially backoff when there is connection loss exception, which will give hbase much longer time window to recover from zk machine failures. This addresses bug HBASE-4568 . https://issues.apache.org/jira/browse/HBASE-4568 Diffs ----- src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java 61ea552 src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java b8c4f61 src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 699a5f5 src/main/resources/hbase-webapps/master/zk.jsp b31d94c Diff: https://reviews.apache.org/r/2385/diff Testing ------- Running all the unit tests Thanks, Liyin
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2385/
        -----------------------------------------------------------

        (Updated 2011-10-13 22:36:46.694728)

        Review request for hbase, Dhruba Borthakur, Michael Stack, Jonathan Gray, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg.

        Summary
        -------

        1) For each zk dump, currently hbase will create a zk client instance every time.
        This is quite slow when any machines in the quorum is dead. Because it will connect to each machine in the zk quorum again.

        <code>
        HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);
        Configuration conf = master.getConfiguration();
        HBaseAdmin hbadmin = new HBaseAdmin(conf);
        HConnection connection = hbadmin.getConnection();
        ZooKeeperWatcher watcher = connection.getZooKeeperWatcher();
        </code>

        So we can simplify this:
        <code>
        HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);
        ZooKeeperWatcher watcher = master.getZooKeeperWatcher();
        </code>

        2) Also when hbase call getServerStats() for each machine in the zk quorum, it hard coded the default time out as 1 min.
        It would be nice to make this configurable and set it to a low time out.

        When hbase tries to connect to each machine in the zk quorum, it will create the socket, and then set the socket time out, and read it with this time out.
        It means hbase will create a socket and connect to the zk server with 0 time out at first, which will take a long time.
        Because a timeout of zero is interpreted as an infinite timeout. The connection will then block until established or an error occurs.

        3) The recoverable zookeeper should be real exponentially backoff when there is connection loss exception, which will give hbase much longer time window to recover from zk machine failures.

        This addresses bug HBASE-4568.
        https://issues.apache.org/jira/browse/HBASE-4568

        Diffs (updated)


        src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java 61ea552
        src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java b8c4f61
        src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 699a5f5
        src/main/resources/hbase-webapps/master/zk.jsp b31d94c

        Diff: https://reviews.apache.org/r/2385/diff

        Testing
        -------

        Running all the unit tests

        Thanks,

        Liyin

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2385/ ----------------------------------------------------------- (Updated 2011-10-13 22:36:46.694728) Review request for hbase, Dhruba Borthakur, Michael Stack, Jonathan Gray, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg. Summary ------- 1) For each zk dump, currently hbase will create a zk client instance every time. This is quite slow when any machines in the quorum is dead. Because it will connect to each machine in the zk quorum again. <code> HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER); Configuration conf = master.getConfiguration(); HBaseAdmin hbadmin = new HBaseAdmin(conf); HConnection connection = hbadmin.getConnection(); ZooKeeperWatcher watcher = connection.getZooKeeperWatcher(); </code> So we can simplify this: <code> HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER); ZooKeeperWatcher watcher = master.getZooKeeperWatcher(); </code> 2) Also when hbase call getServerStats() for each machine in the zk quorum, it hard coded the default time out as 1 min. It would be nice to make this configurable and set it to a low time out. When hbase tries to connect to each machine in the zk quorum, it will create the socket, and then set the socket time out, and read it with this time out. It means hbase will create a socket and connect to the zk server with 0 time out at first, which will take a long time. Because a timeout of zero is interpreted as an infinite timeout. The connection will then block until established or an error occurs. 3) The recoverable zookeeper should be real exponentially backoff when there is connection loss exception, which will give hbase much longer time window to recover from zk machine failures. This addresses bug HBASE-4568 . https://issues.apache.org/jira/browse/HBASE-4568 Diffs (updated) src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java 61ea552 src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java b8c4f61 src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 699a5f5 src/main/resources/hbase-webapps/master/zk.jsp b31d94c Diff: https://reviews.apache.org/r/2385/diff Testing ------- Running all the unit tests Thanks, Liyin
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2385/
        -----------------------------------------------------------

        (Updated 2011-10-13 22:33:54.109200)

        Review request for hbase, Dhruba Borthakur, Michael Stack, Jonathan Gray, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg.

        Changes
        -------

        Remove trailing space.

        Summary
        -------

        1) For each zk dump, currently hbase will create a zk client instance every time.
        This is quite slow when any machines in the quorum is dead. Because it will connect to each machine in the zk quorum again.

        <code>
        HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);
        Configuration conf = master.getConfiguration();
        HBaseAdmin hbadmin = new HBaseAdmin(conf);
        HConnection connection = hbadmin.getConnection();
        ZooKeeperWatcher watcher = connection.getZooKeeperWatcher();
        </code>

        So we can simplify this:
        <code>
        HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);
        ZooKeeperWatcher watcher = master.getZooKeeperWatcher();
        </code>

        2) Also when hbase call getServerStats() for each machine in the zk quorum, it hard coded the default time out as 1 min.
        It would be nice to make this configurable and set it to a low time out.

        When hbase tries to connect to each machine in the zk quorum, it will create the socket, and then set the socket time out, and read it with this time out.
        It means hbase will create a socket and connect to the zk server with 0 time out at first, which will take a long time.
        Because a timeout of zero is interpreted as an infinite timeout. The connection will then block until established or an error occurs.

        3) The recoverable zookeeper should be real exponentially backoff when there is connection loss exception, which will give hbase much longer time window to recover from zk machine failures.

        This addresses bug HBASE-4568.
        https://issues.apache.org/jira/browse/HBASE-4568

        Diffs (updated)


        src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java 61ea552
        src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java b8c4f61
        src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 699a5f5
        src/main/resources/hbase-webapps/master/zk.jsp b31d94c

        Diff: https://reviews.apache.org/r/2385/diff

        Testing
        -------

        Running all the unit tests

        Thanks,

        Liyin

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2385/ ----------------------------------------------------------- (Updated 2011-10-13 22:33:54.109200) Review request for hbase, Dhruba Borthakur, Michael Stack, Jonathan Gray, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg. Changes ------- Remove trailing space. Summary ------- 1) For each zk dump, currently hbase will create a zk client instance every time. This is quite slow when any machines in the quorum is dead. Because it will connect to each machine in the zk quorum again. <code> HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER); Configuration conf = master.getConfiguration(); HBaseAdmin hbadmin = new HBaseAdmin(conf); HConnection connection = hbadmin.getConnection(); ZooKeeperWatcher watcher = connection.getZooKeeperWatcher(); </code> So we can simplify this: <code> HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER); ZooKeeperWatcher watcher = master.getZooKeeperWatcher(); </code> 2) Also when hbase call getServerStats() for each machine in the zk quorum, it hard coded the default time out as 1 min. It would be nice to make this configurable and set it to a low time out. When hbase tries to connect to each machine in the zk quorum, it will create the socket, and then set the socket time out, and read it with this time out. It means hbase will create a socket and connect to the zk server with 0 time out at first, which will take a long time. Because a timeout of zero is interpreted as an infinite timeout. The connection will then block until established or an error occurs. 3) The recoverable zookeeper should be real exponentially backoff when there is connection loss exception, which will give hbase much longer time window to recover from zk machine failures. This addresses bug HBASE-4568 . https://issues.apache.org/jira/browse/HBASE-4568 Diffs (updated) src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java 61ea552 src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java b8c4f61 src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 699a5f5 src/main/resources/hbase-webapps/master/zk.jsp b31d94c Diff: https://reviews.apache.org/r/2385/diff Testing ------- Running all the unit tests Thanks, Liyin
        Hide
        jiraposter@reviews.apache.org added a comment -

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        https://reviews.apache.org/r/2385/
        -----------------------------------------------------------

        Review request for hbase, Dhruba Borthakur, Michael Stack, Jonathan Gray, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg.

        Summary
        -------

        1) For each zk dump, currently hbase will create a zk client instance every time.
        This is quite slow when any machines in the quorum is dead. Because it will connect to each machine in the zk quorum again.

        <code>
        HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);
        Configuration conf = master.getConfiguration();
        HBaseAdmin hbadmin = new HBaseAdmin(conf);
        HConnection connection = hbadmin.getConnection();
        ZooKeeperWatcher watcher = connection.getZooKeeperWatcher();
        </code>

        So we can simplify this:
        <code>
        HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER);
        ZooKeeperWatcher watcher = master.getZooKeeperWatcher();
        </code>

        2) Also when hbase call getServerStats() for each machine in the zk quorum, it hard coded the default time out as 1 min.
        It would be nice to make this configurable and set it to a low time out.

        When hbase tries to connect to each machine in the zk quorum, it will create the socket, and then set the socket time out, and read it with this time out.
        It means hbase will create a socket and connect to the zk server with 0 time out at first, which will take a long time.
        Because a timeout of zero is interpreted as an infinite timeout. The connection will then block until established or an error occurs.

        3) The recoverable zookeeper should be real exponentially backoff when there is connection loss exception, which will give hbase much longer time window to recover from zk machine failures.

        This addresses bug HBASE-4568.
        https://issues.apache.org/jira/browse/HBASE-4568

        Diffs


        src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java 61ea552
        src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java b8c4f61
        src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 699a5f5
        src/main/resources/hbase-webapps/master/zk.jsp b31d94c

        Diff: https://reviews.apache.org/r/2385/diff

        Testing
        -------

        Running all the unit tests

        Thanks,

        Liyin

        Show
        jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2385/ ----------------------------------------------------------- Review request for hbase, Dhruba Borthakur, Michael Stack, Jonathan Gray, Mikhail Bautin, Pritam Damania, Prakash Khemani, Amitanand Aiyer, Kannan Muthukkaruppan, Jerry Chen, Karthik Ranganathan, and Nicolas Spiegelberg. Summary ------- 1) For each zk dump, currently hbase will create a zk client instance every time. This is quite slow when any machines in the quorum is dead. Because it will connect to each machine in the zk quorum again. <code> HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER); Configuration conf = master.getConfiguration(); HBaseAdmin hbadmin = new HBaseAdmin(conf); HConnection connection = hbadmin.getConnection(); ZooKeeperWatcher watcher = connection.getZooKeeperWatcher(); </code> So we can simplify this: <code> HMaster master = (HMaster)getServletContext().getAttribute(HMaster.MASTER); ZooKeeperWatcher watcher = master.getZooKeeperWatcher(); </code> 2) Also when hbase call getServerStats() for each machine in the zk quorum, it hard coded the default time out as 1 min. It would be nice to make this configurable and set it to a low time out. When hbase tries to connect to each machine in the zk quorum, it will create the socket, and then set the socket time out, and read it with this time out. It means hbase will create a socket and connect to the zk server with 0 time out at first, which will take a long time. Because a timeout of zero is interpreted as an infinite timeout. The connection will then block until established or an error occurs. 3) The recoverable zookeeper should be real exponentially backoff when there is connection loss exception, which will give hbase much longer time window to recover from zk machine failures. This addresses bug HBASE-4568 . https://issues.apache.org/jira/browse/HBASE-4568 Diffs src/main/java/org/apache/hadoop/hbase/util/RetryCounter.java 61ea552 src/main/java/org/apache/hadoop/hbase/zookeeper/RecoverableZooKeeper.java b8c4f61 src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java 699a5f5 src/main/resources/hbase-webapps/master/zk.jsp b31d94c Diff: https://reviews.apache.org/r/2385/diff Testing ------- Running all the unit tests Thanks, Liyin
        Hide
        stack added a comment -

        +1 Liyin.

        Show
        stack added a comment - +1 Liyin.

          People

          • Assignee:
            Liyin Tang
            Reporter:
            Liyin Tang
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development