HBase
  1. HBase
  2. HBASE-4559

Refactor TestAvroServer into an integration test

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Invalid
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: test
    • Labels:
      None

      Description

      TestAvroServer is a beefy test, spins up a mini cluster, does a large series of manipulations and then spins it down. It take about 2 mins to run on a local machine, which on the high side for a 'unit' test.

      This is part of the implentation discussed in http://search-hadoop.com/m/L9OzBNEOJK1

        Issue Links

          Activity

          Hide
          Jesse Yates added a comment -

          Attached patch does not add any new unit test for avro server since everything in avro server seems to be just pass through functionality to the table admin. All the other functionality is covered already by TestAvroUtil.

          Show
          Jesse Yates added a comment - Attached patch does not add any new unit test for avro server since everything in avro server seems to be just pass through functionality to the table admin. All the other functionality is covered already by TestAvroUtil.
          Hide
          stack added a comment -

          This is a good test to move out since its being flakey in 0.92 (though the why needs fixing).

          Patch looks good but when I did:

          mvn -DskipTests verify
          

          The new test did not run. Is this me?

          Show
          stack added a comment - This is a good test to move out since its being flakey in 0.92 (though the why needs fixing). Patch looks good but when I did: mvn -DskipTests verify The new test did not run. Is this me?
          Hide
          stack added a comment -

          Or is it just that verify will only run if skipTests is NOT set as per above?

          Show
          stack added a comment - Or is it just that verify will only run if skipTests is NOT set as per above?
          Hide
          Jesse Yates added a comment -

          hmmm, its looking like 'tests' count as integration tests too. Checking on this...

          Show
          Jesse Yates added a comment - hmmm, its looking like 'tests' count as integration tests too. Checking on this...
          Hide
          Jesse Yates added a comment -

          okay, here is the deal. To just run integration tests, use:

          mvn failsafe:integration-test
          

          to run the integration tests. And then

          mvn failsafe:verify
          

          to verify the output results. That is when you will find out if the integration tests fail.
          If you don't run the latter, then maven outputs success, even if you have integration test failures.

          Show
          Jesse Yates added a comment - okay, here is the deal. To just run integration tests, use: mvn failsafe:integration-test to run the integration tests. And then mvn failsafe:verify to verify the output results. That is when you will find out if the integration tests fail. If you don't run the latter, then maven outputs success, even if you have integration test failures.
          Hide
          Ted Yu added a comment -

          @Jesse, @Doug:
          I think Jesse's comment @ 12/Oct/11 21:59 should be put into hbase book.

          Show
          Ted Yu added a comment - @Jesse, @Doug: I think Jesse's comment @ 12/Oct/11 21:59 should be put into hbase book.
          Hide
          stack added a comment -

          @Ted Agree. Let me do it on commit. Will commit in a while. Thanks Jesse.

          Show
          stack added a comment - @Ted Agree. Let me do it on commit. Will commit in a while. Thanks Jesse.
          Hide
          Jesse Yates added a comment -

          Marking invalid. With Keywals' work on the different sized tests, we don't need to worry about this.

          Show
          Jesse Yates added a comment - Marking invalid. With Keywals' work on the different sized tests, we don't need to worry about this.

            People

            • Assignee:
              Jesse Yates
              Reporter:
              Jesse Yates
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development