HBase
  1. HBase
  2. HBASE-4550

When master passed regionserver different address , because regionserver didn't create new zookeeper znode, as a result stop-hbase.sh is hang

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Not A Problem
    • Affects Version/s: 0.90.3
    • Fix Version/s: 0.90.7
    • Component/s: regionserver
    • Labels:
      None

      Description

      when master passed regionserver different address, regionserver didn't create new zookeeper znode, master store new address in ServerManager, when call stop-hbase.sh , RegionServerTracker.nodeDeleted received path is old address, serverManager.expireServer is not be called. so stop-hbase.sh is hang.

      1. hbase-0.90.3.patch
        0.9 kB
        wanbin
      2. patch
        0.6 kB
        wanbin
      3. patch.txt
        0.9 kB
        wanbin

        Activity

        wanbin created issue -
        wanbin made changes -
        Field Original Value New Value
        Fix Version/s 0.90.4 [ 12316406 ]
        wanbin made changes -
        Attachment patch [ 12498142 ]
        Hide
        wanbin added a comment -

        I fixed this problem, somebody can check it. thanks.

        Show
        wanbin added a comment - I fixed this problem, somebody can check it. thanks.
        Hide
        stack added a comment -

        +1 on patch. Should we apply to 0.90?

        Show
        stack added a comment - +1 on patch. Should we apply to 0.90?
        stack made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hadoop Flags Reviewed [ 10343 ]
        Fix Version/s 0.90.5 [ 12317145 ]
        Ted Yu made changes -
        Assignee wanbin [ wanbin ]
        Hide
        Ted Yu added a comment -

        @Wanbin:
        The patch is a diff file.
        Can you produce patch files for 0.90 and 0.92 ?

        Good job.

        Show
        Ted Yu added a comment - @Wanbin: The patch is a diff file. Can you produce patch files for 0.90 and 0.92 ? Good job.
        Hide
        wanbin added a comment -

        I use 0.90.3 , so I produce patch files for 0.90.3.
        I checkout 0.92 sourcecode, find handleReportForDutyResponse() has more differnce. I don't know if 0.92 has this problem.

        Show
        wanbin added a comment - I use 0.90.3 , so I produce patch files for 0.90.3. I checkout 0.92 sourcecode, find handleReportForDutyResponse() has more differnce. I don't know if 0.92 has this problem.
        wanbin made changes -
        Attachment hbase-0.90.3.patch [ 12499861 ]
        Hide
        stack added a comment -

        +1 on committing to 0.90 branch. We do not have this issue on 0.92 and TRUNK because we do not register in zk until AFTER we report for duty (report for duty is where master can tell us use a different name).

        Show
        stack added a comment - +1 on committing to 0.90 branch. We do not have this issue on 0.92 and TRUNK because we do not register in zk until AFTER we report for duty (report for duty is where master can tell us use a different name).
        Hide
        Ted Yu added a comment -

        @wanbin:
        Can you check out 0.90 HEAD and provide a patch ?

        Also, indentation is slightly off.
        See HBASE-3678 for Eclipse formatter.

        Thanks

        Show
        Ted Yu added a comment - @wanbin: Can you check out 0.90 HEAD and provide a patch ? Also, indentation is slightly off. See HBASE-3678 for Eclipse formatter. Thanks
        wanbin made changes -
        Attachment patch.txt [ 12500461 ]
        Hide
        wanbin added a comment -

        ok.

        Show
        wanbin added a comment - ok.
        stack made changes -
        Fix Version/s 0.90.6 [ 12319200 ]
        Fix Version/s 0.90.5 [ 12317145 ]
        Hide
        ramkrishna.s.vasudevan added a comment -

        @Wanbin
        If you provide a new patch can be integrated to 0.90.7
        Moving to 0.90.7

        Show
        ramkrishna.s.vasudevan added a comment - @Wanbin If you provide a new patch can be integrated to 0.90.7 Moving to 0.90.7
        ramkrishna.s.vasudevan made changes -
        Fix Version/s 0.90.7 [ 12319481 ]
        Fix Version/s 0.90.6 [ 12319200 ]
        Hide
        wanbin added a comment -

        I check hbase trunk code , it's seem no problem.

        Show
        wanbin added a comment - I check hbase trunk code , it's seem no problem.
        Andrew Purtell made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags Reviewed [ 10343 ]
        Assignee wanbin [ wanbin ]
        Resolution Not A Problem [ 8 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        5d 17h 11m 1 stack 12/Oct/11 22:32
        Patch Available Patch Available Resolved Resolved
        1276d 2h 46m 1 Andrew Purtell 11/Apr/15 01:18

          People

          • Assignee:
            Unassigned
            Reporter:
            wanbin
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development