HBase
  1. HBase
  2. HBASE-4550

When master passed regionserver different address , because regionserver didn't create new zookeeper znode, as a result stop-hbase.sh is hang

    Details

    • Type: Bug Bug
    • Status: Patch Available
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: 0.90.3
    • Fix Version/s: 0.90.7
    • Component/s: regionserver
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      when master passed regionserver different address, regionserver didn't create new zookeeper znode, master store new address in ServerManager, when call stop-hbase.sh , RegionServerTracker.nodeDeleted received path is old address, serverManager.expireServer is not be called. so stop-hbase.sh is hang.

      1. patch
        0.6 kB
        wanbin
      2. hbase-0.90.3.patch
        0.9 kB
        wanbin
      3. patch.txt
        0.9 kB
        wanbin

        Activity

        Hide
        wanbin added a comment -

        I fixed this problem, somebody can check it. thanks.

        Show
        wanbin added a comment - I fixed this problem, somebody can check it. thanks.
        Hide
        stack added a comment -

        +1 on patch. Should we apply to 0.90?

        Show
        stack added a comment - +1 on patch. Should we apply to 0.90?
        Hide
        Ted Yu added a comment -

        @Wanbin:
        The patch is a diff file.
        Can you produce patch files for 0.90 and 0.92 ?

        Good job.

        Show
        Ted Yu added a comment - @Wanbin: The patch is a diff file. Can you produce patch files for 0.90 and 0.92 ? Good job.
        Hide
        wanbin added a comment -

        I use 0.90.3 , so I produce patch files for 0.90.3.
        I checkout 0.92 sourcecode, find handleReportForDutyResponse() has more differnce. I don't know if 0.92 has this problem.

        Show
        wanbin added a comment - I use 0.90.3 , so I produce patch files for 0.90.3. I checkout 0.92 sourcecode, find handleReportForDutyResponse() has more differnce. I don't know if 0.92 has this problem.
        Hide
        stack added a comment -

        +1 on committing to 0.90 branch. We do not have this issue on 0.92 and TRUNK because we do not register in zk until AFTER we report for duty (report for duty is where master can tell us use a different name).

        Show
        stack added a comment - +1 on committing to 0.90 branch. We do not have this issue on 0.92 and TRUNK because we do not register in zk until AFTER we report for duty (report for duty is where master can tell us use a different name).
        Hide
        Ted Yu added a comment -

        @wanbin:
        Can you check out 0.90 HEAD and provide a patch ?

        Also, indentation is slightly off.
        See HBASE-3678 for Eclipse formatter.

        Thanks

        Show
        Ted Yu added a comment - @wanbin: Can you check out 0.90 HEAD and provide a patch ? Also, indentation is slightly off. See HBASE-3678 for Eclipse formatter. Thanks
        Hide
        wanbin added a comment -

        ok.

        Show
        wanbin added a comment - ok.
        Hide
        ramkrishna.s.vasudevan added a comment -

        @Wanbin
        If you provide a new patch can be integrated to 0.90.7
        Moving to 0.90.7

        Show
        ramkrishna.s.vasudevan added a comment - @Wanbin If you provide a new patch can be integrated to 0.90.7 Moving to 0.90.7
        Hide
        wanbin added a comment -

        I check hbase trunk code , it's seem no problem.

        Show
        wanbin added a comment - I check hbase trunk code , it's seem no problem.

          People

          • Assignee:
            wanbin
            Reporter:
            wanbin
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Time Tracking

              Estimated:
              Original Estimate - 2h
              2h
              Remaining:
              Remaining Estimate - 2h
              2h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development