[HBASE-4471] HTable.close() should shut down executor pool

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Duplicate
• Affects Version/s: 0.90.3
• Component/s: Client
• Assignee: Unassigned
• Reporter: Josh Rosenblum
• Created: 23/Sep/11 18:21
• Updated: 12/Jun/22 19:36
• Resolved: 26/Sep/11 17:27

Description

Right now, it looks like HTable.close() is primarily concerned with flushing commits. I understand the intended semantics of close to be that clients should not attempt to call any other methods on that HTable instance after close is called. If that's true, then close() might leave around some relatively heavy resources after close() is called that can serve no further purpose. In particular, the executor this.pool may have a number of threads outstanding for some period of time (a minute with the default keepAliveTime of 60). With the default number of threads == the number of regionservers and with each thread having a 1mb stack by default on 64-bit jvms, this can be a considerable amount of memory left around (in addition to any other resources consumed by each thread). Is there any reason for close() not to also call this.pool.shutdown() after it calls flushCommits()?

Issue Links

• is related to: HBASE-3750 HTablePool.putTable() should call tableFactory.releaseHTableInterface() for discarded table