HBase
  1. HBase
  2. HBASE-4454

Add failsafe plugin to build and rename integration tests

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.92.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Add the maven-failsafe-plugin to the build process so we can run integration tests with "mvn verify". This will also involve a renaming of integration tests to conform to a new integration test regex.

      This is a stopgap measure while we until break them out into their own module.

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in HBase-0.92 #42 (See https://builds.apache.org/job/HBase-0.92/42/)
          HBASE-4531 hbase-4454 failsafe broke mvn site; back it out or fix

          Show
          Hudson added a comment - Integrated in HBase-0.92 #42 (See https://builds.apache.org/job/HBase-0.92/42/ ) HBASE-4531 hbase-4454 failsafe broke mvn site; back it out or fix
          Hide
          Hudson added a comment -

          Integrated in HBase-0.92 #40 (See https://builds.apache.org/job/HBase-0.92/40/)
          HBASE-4531 hbase-4454 failsafe broke mvn site; back it out or fix

          Show
          Hudson added a comment - Integrated in HBase-0.92 #40 (See https://builds.apache.org/job/HBase-0.92/40/ ) HBASE-4531 hbase-4454 failsafe broke mvn site; back it out or fix
          Hide
          Jesse Yates added a comment -

          @stack - no worries, whenever you get around to it. Thanks for updating the book!

          Show
          Jesse Yates added a comment - @stack - no worries, whenever you get around to it. Thanks for updating the book!
          Hide
          Hudson added a comment -

          Integrated in HBase-0.92 #27 (See https://builds.apache.org/job/HBase-0.92/27/)
          HBASE-4454 Add failsafe plugin to build and rename integration tests

          stack :
          Files :

          • /hbase/branches/0.92/CHANGES.txt
          • /hbase/branches/0.92/pom.xml
          Show
          Hudson added a comment - Integrated in HBase-0.92 #27 (See https://builds.apache.org/job/HBase-0.92/27/ ) HBASE-4454 Add failsafe plugin to build and rename integration tests stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/pom.xml
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2267 (See https://builds.apache.org/job/HBase-TRUNK/2267/)
          HBASE-4454 Add failsafe plugin to build and rename integration tests

          stack :
          Files :

          • /hbase/trunk/CHANGES.txt
          • /hbase/trunk/pom.xml
          • /hbase/trunk/src/docbkx/developer.xml
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2267 (See https://builds.apache.org/job/HBase-TRUNK/2267/ ) HBASE-4454 Add failsafe plugin to build and rename integration tests stack : Files : /hbase/trunk/CHANGES.txt /hbase/trunk/pom.xml /hbase/trunk/src/docbkx/developer.xml
          Hide
          stack added a comment -

          Committed to 0.92 branch and trunk. Thanks for the patch Jesse. I added a bit of doc. to the book – a new section after the unit test section in developer chapter on 'integration tests'. See below.

          I'm trying to add you as a contributor Jesse so I can assign you the issue so you can start accumulating credit but they just updated JIRA and I'm having trouble figuring how with the new interface. I'll figure it eventually....

                  <section xml:id="integration.tests">
                    <title>Integration Tests</title>
                    <para>HBase 0.92 added a <varname>verify</varname> maven target.  Invocation will
                    run a suite of long-running tests via the maven <link xlink:href="http://maven.apache.org/plugins/maven-failsafe-plugin/">failsafe plugin</link>.
                    </para>
                   </section>
          
          Show
          stack added a comment - Committed to 0.92 branch and trunk. Thanks for the patch Jesse. I added a bit of doc. to the book – a new section after the unit test section in developer chapter on 'integration tests'. See below. I'm trying to add you as a contributor Jesse so I can assign you the issue so you can start accumulating credit but they just updated JIRA and I'm having trouble figuring how with the new interface. I'll figure it eventually.... <section xml:id= "integration.tests" > <title>Integration Tests</title> <para>HBase 0.92 added a <varname>verify</varname> maven target. Invocation will run a suite of long -running tests via the maven <link xlink:href= "http: //maven.apache.org/plugins/maven-failsafe-plugin/" >failsafe plugin</link>. </para> </section>
          Hide
          Jesse Yates added a comment -

          Patch uploaded to separate out running integration tests.

          IntegrationTests must be named as */IntegrationTest.java.

          They can be run with the command: 'mvn verfy'.

          Since verify is part of the standard build phases, under assembly, package, etc, integration tests will be run automatically when doing a full build.

          @Stack: should I open up a separate ticket, new patch version, or just add another patch for updating documentation? Do we even need to update the docs for this?

          Show
          Jesse Yates added a comment - Patch uploaded to separate out running integration tests. IntegrationTests must be named as * /IntegrationTest .java. They can be run with the command: 'mvn verfy'. Since verify is part of the standard build phases, under assembly, package, etc, integration tests will be run automatically when doing a full build. @Stack: should I open up a separate ticket, new patch version, or just add another patch for updating documentation? Do we even need to update the docs for this?
          Hide
          Jesse Yates added a comment -
          Show
          Jesse Yates added a comment - Patch up for this at https://reviews.apache.org/r/2022/
          Hide
          Jesse Yates added a comment -

          This should be a pretty simple switch, pom wise, based on code for HBASE-4336. Most of the work is going to be figuring out which tests need to be moved over.

          Hopefully, I'll have a patch up tonight.

          Show
          Jesse Yates added a comment - This should be a pretty simple switch, pom wise, based on code for HBASE-4336 . Most of the work is going to be figuring out which tests need to be moved over. Hopefully, I'll have a patch up tonight.

            People

            • Assignee:
              Jesse Yates
              Reporter:
              Jesse Yates
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development