HBase
  1. HBase
  2. HBASE-4436

Remove methods deprecated in 0.90 from TRUNK and 0.92

    Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Remove methods deprecated in 0.90 from codebase. i took a quick look. The messy bit is thrift referring to old stuff; will take a little work to do the convertion over to the new methods.

        Activity

        Hide
        Jonathan Hsieh added a comment -

        I'll take this. I'm going to break it down to a few patches. The first will be the completely trivial changes, to be followed by a series of more complicated patches.

        Is removing classes like HServerAddress in scope? (It is pretty pervasive)

        Show
        Jonathan Hsieh added a comment - I'll take this. I'm going to break it down to a few patches. The first will be the completely trivial changes, to be followed by a series of more complicated patches. Is removing classes like HServerAddress in scope? (It is pretty pervasive)
        Hide
        stack added a comment -

        Is removing classes like HServerAddress in scope? (It is pretty pervasive)

        Be careful. HSA is deprecated for 0.92. You'll need to look at what was deprecated in 0.90 and only remove those for 0.92.

        Thanks Jon.

        Show
        stack added a comment - Is removing classes like HServerAddress in scope? (It is pretty pervasive) Be careful. HSA is deprecated for 0.92. You'll need to look at what was deprecated in 0.90 and only remove those for 0.92. Thanks Jon.
        Hide
        Jonathan Hsieh added a comment -

        Already gone:

        Trivial removals:

        • MultiPut*,
        • KevValue.createFirstOnRow,
        • Get.addColumns(byte[][] columns),
        • Put.add(byte[] column, long ts, byte[] value),
        • Delete.deleteColumns(byte[] column),
        • Delete.deleteColumns(byte[] column, long ts)
        • HBaseAdmin.modifyColumn(.., columnName, ..)
        • HColumnDescriptor.CompressionType enum
        • HConnectionManager.processBatchOfPuts / HConnection.processBatchOfPuts
        • Result.sorted()

        Things that require a little work: (touches many places or requires some code, will make separate sub-jiras)

        • RemoteExceptionHandler class (15 refs)
        • Scan methods (4 ref - might have bug)
        • HBaseTestCase class (47 references)

        I didn't encounter and thrift related problems.

        Show
        Jonathan Hsieh added a comment - Already gone: HBaseClusterTestCase ( HBASE-4503 ) HServerLoad.addRegionInfo ( HBASE-1502 ) Trivial removals: MultiPut*, KevValue.createFirstOnRow, Get.addColumns(byte[][] columns), Put.add(byte[] column, long ts, byte[] value), Delete.deleteColumns(byte[] column), Delete.deleteColumns(byte[] column, long ts) HBaseAdmin.modifyColumn(.., columnName, ..) HColumnDescriptor.CompressionType enum HConnectionManager.processBatchOfPuts / HConnection.processBatchOfPuts Result.sorted() Things that require a little work: (touches many places or requires some code, will make separate sub-jiras) RemoteExceptionHandler class (15 refs) Scan methods (4 ref - might have bug) HBaseTestCase class (47 references) I didn't encounter and thrift related problems.
        Hide
        stack added a comment -

        Would be good to get this into 0.92. You fellas are busy I hear Jon.

        Show
        stack added a comment - Would be good to get this into 0.92. You fellas are busy I hear Jon.
        Hide
        Jonathan Hsieh added a comment -

        Yeah, busy busy. Here's where I am now:

        The trivial parts (HBASE-4622) is up for review.

        I have a first cut of scan related (HBASE-4623), but this broke tests – still working on this.

        I haven't started the other two sub parts.

        Show
        Jonathan Hsieh added a comment - Yeah, busy busy. Here's where I am now: The trivial parts ( HBASE-4622 ) is up for review. I have a first cut of scan related ( HBASE-4623 ), but this broke tests – still working on this. I haven't started the other two sub parts.
        Hide
        stack added a comment -

        Bumping down from critical. I applied the bit of Jon's work that is finished. Would be nice to get the other clean up in but won't let it hold up an RC

        Show
        stack added a comment - Bumping down from critical. I applied the bit of Jon's work that is finished. Would be nice to get the other clean up in but won't let it hold up an RC
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2381 (See https://builds.apache.org/job/HBase-TRUNK/2381/)
        HBASE-4436 Remove trivial 0.90 deprecated code from 0.92 and trunk.

        stack :
        Files :

        • /hbase/trunk/CHANGES.txt
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/KeyValue.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Delete.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Get.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Put.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Result.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestSerialization.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TimestampTestBase.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2381 (See https://builds.apache.org/job/HBase-TRUNK/2381/ ) HBASE-4436 Remove trivial 0.90 deprecated code from 0.92 and trunk. stack : Files : /hbase/trunk/CHANGES.txt /hbase/trunk/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/KeyValue.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Delete.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Get.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnection.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/HTable.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Put.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Result.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TestSerialization.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/TimestampTestBase.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #90 (See https://builds.apache.org/job/HBase-0.92/90/)
        HBASE-4436 Remove trivial 0.90 deprecated code from 0.92 and trunk.

        stack :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/KeyValue.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/Delete.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/Get.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HConnection.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HTable.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/Put.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/Result.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java
        • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/TestSerialization.java
        • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/TimestampTestBase.java
        • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java
        • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java
        Show
        Hudson added a comment - Integrated in HBase-0.92 #90 (See https://builds.apache.org/job/HBase-0.92/90/ ) HBASE-4436 Remove trivial 0.90 deprecated code from 0.92 and trunk. stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/HColumnDescriptor.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/KeyValue.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/Delete.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/Get.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HConnection.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/HTable.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/Put.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/Result.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/io/HbaseObjectWritable.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/ipc/HRegionInterface.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/thrift/ThriftUtilities.java /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/TestSerialization.java /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/TimestampTestBase.java /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/client/TestFromClientSide.java /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java
        Hide
        Lars Hofhansl added a comment -

        Should we move this jira to 0.94?
        One of the subtasks is done, the other three moved to 0.94.

        Show
        Lars Hofhansl added a comment - Should we move this jira to 0.94? One of the subtasks is done, the other three moved to 0.94.
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #134 (See https://builds.apache.org/job/HBase-0.92/134/)
        HBASE-4793 HBase shell still using deprecated methods removed in HBASE-4436

        tedyu :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/ruby/hbase/admin.rb
        Show
        Hudson added a comment - Integrated in HBase-0.92 #134 (See https://builds.apache.org/job/HBase-0.92/134/ ) HBASE-4793 HBase shell still using deprecated methods removed in HBASE-4436 tedyu : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/ruby/hbase/admin.rb
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2445 (See https://builds.apache.org/job/HBase-TRUNK/2445/)
        HBASE-4793 HBase shell still using deprecated methods removed in HBASE-4436

        tedyu :
        Files :

        • /hbase/trunk/CHANGES.txt
        • /hbase/trunk/src/main/ruby/hbase/admin.rb
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2445 (See https://builds.apache.org/job/HBase-TRUNK/2445/ ) HBASE-4793 HBase shell still using deprecated methods removed in HBASE-4436 tedyu : Files : /hbase/trunk/CHANGES.txt /hbase/trunk/src/main/ruby/hbase/admin.rb
        Hide
        Hudson added a comment -

        Integrated in HBase-0.92 #146 (See https://builds.apache.org/job/HBase-0.92/146/)
        HBASE-4436 Remove @deprecated Scan methods in 0.90 from TRUNK and 0.92

        stack :
        Files :

        • /hbase/branches/0.92/CHANGES.txt
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/Scan.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/mapred/TableRecordReaderImpl.java
        • /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormat.java
        • /hbase/branches/0.92/src/main/ruby/hbase/table.rb
        • /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java
        Show
        Hudson added a comment - Integrated in HBase-0.92 #146 (See https://builds.apache.org/job/HBase-0.92/146/ ) HBASE-4436 Remove @deprecated Scan methods in 0.90 from TRUNK and 0.92 stack : Files : /hbase/branches/0.92/CHANGES.txt /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/client/Scan.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/mapred/TableRecordReaderImpl.java /hbase/branches/0.92/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormat.java /hbase/branches/0.92/src/main/ruby/hbase/table.rb /hbase/branches/0.92/src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2460 (See https://builds.apache.org/job/HBase-TRUNK/2460/)
        HBASE-4436 Remove @deprecated Scan methods in 0.90 from TRUNK and 0.92

        stack :
        Files :

        • /hbase/trunk/CHANGES.txt
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Scan.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapred/TableRecordReaderImpl.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormat.java
        • /hbase/trunk/src/main/ruby/hbase/table.rb
        • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2460 (See https://builds.apache.org/job/HBase-TRUNK/2460/ ) HBASE-4436 Remove @deprecated Scan methods in 0.90 from TRUNK and 0.92 stack : Files : /hbase/trunk/CHANGES.txt /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Scan.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapred/TableRecordReaderImpl.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/TableInputFormat.java /hbase/trunk/src/main/ruby/hbase/table.rb /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapred/TestTableMapReduce.java
        Hide
        Jesse Yates added a comment -

        How much is left on this? Should we even still keep it open, especially given that we cut 0.94?

        Show
        Jesse Yates added a comment - How much is left on this? Should we even still keep it open, especially given that we cut 0.94?
        Hide
        Jonathan Hsieh added a comment -

        There is no development on 0.90 and 0.92 anymore, so this is not relevant.

        Show
        Jonathan Hsieh added a comment - There is no development on 0.90 and 0.92 anymore, so this is not relevant.
        Hide
        Hudson added a comment -

        FAILURE: Integrated in HBase-TRUNK #5349 (See https://builds.apache.org/job/HBase-TRUNK/5349/)
        HBASE-4436 Remove and convert @deprecated RemoteExceptionHandler.decodeRemoteException calls (Talat Uyarer) (stack: rev 6a74ef15427a9e7b621101abb7de40086188027d)

        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LogRoller.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/util/HMerge.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionMergeRequest.java
        • hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/RemoteExceptionHandler.java
        • hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java
        Show
        Hudson added a comment - FAILURE: Integrated in HBase-TRUNK #5349 (See https://builds.apache.org/job/HBase-TRUNK/5349/ ) HBASE-4436 Remove and convert @deprecated RemoteExceptionHandler.decodeRemoteException calls (Talat Uyarer) (stack: rev 6a74ef15427a9e7b621101abb7de40086188027d) hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SplitRequest.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplitThread.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/LogRoller.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MemStoreFlusher.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/HLogSplitter.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/HMerge.java hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionMergeRequest.java hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java hbase-client/src/main/java/org/apache/hadoop/hbase/RemoteExceptionHandler.java hbase-client/src/main/java/org/apache/hadoop/hbase/client/ScannerCallable.java

          People

          • Assignee:
            Jonathan Hsieh
            Reporter:
            stack
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development