Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.2.0
    • Fix Version/s: 0.2.0
    • Component/s: None
    • Labels:
      None

      Description

      • QueueEntry
      • CompactSplitThread
      • Flusher
      • LogRoller
      • Worker
      1. 442.patch
        35 kB
        Bryan Duxbury

        Issue Links

          Activity

          Hide
          Bryan Duxbury added a comment -

          QueueEntry has a setExpiration method so its member can't be final. I made the rest into finals.

          Committed.

          Show
          Bryan Duxbury added a comment - QueueEntry has a setExpiration method so its member can't be final. I made the rest into finals. Committed.
          Hide
          stack added a comment -

          Can the LogRoller data members server and conf not also be final? Same for 'private long expirationTime;' in QueueEntry. Also some possibles in Flusher (even the lock could be final? since it never changes).

          This is a very nice clean up. Fix above and commit.

          Show
          stack added a comment - Can the LogRoller data members server and conf not also be final? Same for 'private long expirationTime;' in QueueEntry. Also some possibles in Flusher (even the lock could be final? since it never changes). This is a very nice clean up. Fix above and commit.
          Hide
          Bryan Duxbury added a comment -

          Review please.

          Show
          Bryan Duxbury added a comment - Review please.
          Hide
          Bryan Duxbury added a comment -

          Here it is. Passes tests locally.

          Show
          Bryan Duxbury added a comment - Here it is. Passes tests locally.

            People

            • Assignee:
              Bryan Duxbury
              Reporter:
              Bryan Duxbury
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development