HBase
  1. HBase
  2. HBASE-4420

MasterObserver preMove() and postMove() should throw IOException instead of UnknownRegionException

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.92.0
    • Component/s: Coprocessors
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We've standardized on IOException as the main way for coprocessors to communicate errors back out of the Observer hooks. All Observer hooks throw IOE except for MasterObserver.preMove() and MasterObserver.postMove(), which throw UnknownRegionException, since that's what HMasterInterface.move() declares. In hindsight, making these two MasterObserver methods inconsistent seems like a mistake.

      I think we should change MasterObserver.preMove() and MasterObserver.postMove() to throw IOException for consistency with the other methods. We could deprecate the existing HMasterInterface.move() method to have it switch over to throwing IOException as well, but this would require creating a version with a new name, which seems unnecessarily ugly. So I'd suggest we just have HMaster.move() handle the IOException and use it to init an UnknownRegionException. Wonky as that is, it seems the lesser evil.

      1. HBASE-4420.patch
        6 kB
        Gary Helmling

        Issue Links

          Activity

          Gary Helmling created issue -
          Eugene Koontz made changes -
          Field Original Value New Value
          Link This issue blocks HBASE-4014 [ HBASE-4014 ]
          Gary Helmling made changes -
          Attachment HBASE-4420.patch [ 12494851 ]
          Gary Helmling made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Assignee Gary Helmling [ ghelmling ]
          Fix Version/s 0.92.0 [ 12314223 ]
          Resolution Fixed [ 1 ]
          Gavin made changes -
          Link This issue blocks HBASE-4014 [ HBASE-4014 ]
          Gavin made changes -
          Link This issue is depended upon by HBASE-4014 [ HBASE-4014 ]

            People

            • Assignee:
              Gary Helmling
              Reporter:
              Gary Helmling
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development