HBase
  1. HBase
  2. HBASE-4410

FilterList.filterKeyValue can return suboptimal ReturnCodes

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: Filters
    • Labels:
      None

      Description

      FilterList.filterKeyValue does not always return the most optimal ReturnCode in both the AND and OR conditions.

      For example, if you have F1 AND F2, F1 returns SKIP. It immediately returns the SKIP. However, if F2 would have returned NEXT_COL or NEXT_ROW or SEEK_NEXT_USING_HINT, we would actually be able to return the more optimal ReturnCode from F2.

      For AND conditions, we can always pick the most restrictive return code.

      For OR conditions, we must always pick the least restrictive return code.

      This JIRA is to review the FilterList.filterKeyValue() method to try and make it more optimal and to add a new unit test which verifies the correct behavior.

        Activity

        Jonathan Gray created issue -
        Jonathan Gray made changes -
        Field Original Value New Value
        Attachment HBASE-4410-v1.patch [ 12494532 ]
        Ted Yu made changes -
        Fix Version/s 0.94.0 [ 12316419 ]
        Fix Version/s 0.92.0 [ 12314223 ]
        Lars Hofhansl made changes -
        Fix Version/s 0.96.0 [ 12320040 ]
        Fix Version/s 0.94.0 [ 12316419 ]
        stack made changes -
        Fix Version/s 0.96.0 [ 12320040 ]

          People

          • Assignee:
            Jonathan Gray
            Reporter:
            Jonathan Gray
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:

              Development