[HBASE-4390] [replication] ReplicationSource's UncaughtExceptionHandler shouldn't join

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.90.4
• Fix Version/s: 0.90.5
• Hadoop Flags: Reviewed
• Assignee: Jean-Daniel Cryans
• Reporter: Jean-Daniel Cryans
• Created: 13/Sep/11 20:58
• Updated: 20/Nov/15 11:54
• Resolved: 15/Sep/11 22:41

Description

From Jeff Whiting on the ML:

"regionserver60020.replicationSource,dev2" daemon prio=10 tid=0x00002aaaf0312800 nid=0x69f8 in Object.wait() [0x000000004533e000]
java.lang.Thread.State: TIMED_WAITING (on object monitor)
at java.lang.Object.wait(Native Method)

• waiting on <0x00002aaab12464c0> (a org.apache.hadoop.hbase.replication.regionserver.ReplicationSource)
  at java.lang.Thread.join(Thread.java:1151)
• locked <0x00002aaab12464c0> (a org.apache.hadoop.hbase.replication.regionserver.ReplicationSource)
  at org.apache.hadoop.hbase.util.Threads.shutdown(Threads.java:91)
  at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource.terminate(ReplicationSource.java:649)
  at org.apache.hadoop.hbase.replication.regionserver.ReplicationSource$1.uncaughtException(ReplicationSource.java:628)
  at java.lang.Thread.dispatchUncaughtException(Thread.java:1831)

That's pretty dumb, the thread is trying to join itself. UncaughtExceptionHandler shouldn't try to terminate() but just clear resources and then return.