HBase
  1. HBase
  2. HBASE-4359

Show dead RegionServer names in the HMaster info page

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.90.4
    • Fix Version/s: 0.92.0
    • Component/s: master
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Unlike other components of the cluster, like NameNode and JobTracker pages, the HMaster's info page does not show any data on dead region servers. While an RS is stateless being a good reason not to count dead nodes, I think having a list of dead nodes helps in cases where an administrator would want to find out which nodes are missing out on RS action (hey, everyone likes consistently spiking graphs! ).

      Following HBASE-3580, I think it makes sense to have a list of already maintained dead nodes show up in the info UI.

      1. HBASE-4359.r1.diff
        4 kB
        Harsh J
      2. HBase Master UI - Dead Servers.png
        18 kB
        Harsh J
      3. HBASE-4359.r2.diff
        4 kB
        Harsh J
      4. HBase Master UI - Dead Servers (Yes, still dead).png
        17 kB
        Harsh J

        Issue Links

          Activity

          Hide
          Harsh J added a comment -

          Jamon+tests patch that adds in the improvement. Please review!

          I ran the updated master status servlet test.

          -> mvn -Dtest=TestMasterStatusServlet test
          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.hbase.master.TestMasterStatusServlet
          Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.93 sec
          
          Results :
          
          Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
          

          I also ran the build manually via bin/start-hbase.sh with proper config and HDFS running. The screenshot shows the implementation.

          Thanks in advance for reviews!

          Show
          Harsh J added a comment - Jamon+tests patch that adds in the improvement. Please review! I ran the updated master status servlet test. -> mvn -Dtest=TestMasterStatusServlet test ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.hbase.master.TestMasterStatusServlet Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.93 sec Results : Tests run: 5, Failures: 0, Errors: 0, Skipped: 0 I also ran the build manually via bin/start-hbase.sh with proper config and HDFS running. The screenshot shows the implementation. Thanks in advance for reviews!
          Hide
          Harsh J added a comment -

          Newer patch after a chat with Todd. Made it more consistent with the online listing.

          In brightest day, in darkest night, no test case shall escape my sight:

          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          
          -------------------------------------------------------
           T E S T S
          -------------------------------------------------------
          Running org.apache.hadoop.hbase.master.TestMasterStatusServlet
          Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.028 sec
          
          Results :
          
          Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
          

          Also upped a new UI image after manual testing.

          Show
          Harsh J added a comment - Newer patch after a chat with Todd. Made it more consistent with the online listing. In brightest day, in darkest night, no test case shall escape my sight: ------------------------------------------------------- T E S T S ------------------------------------------------------- ------------------------------------------------------- T E S T S ------------------------------------------------------- Running org.apache.hadoop.hbase.master.TestMasterStatusServlet Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.028 sec Results : Tests run: 5, Failures: 0, Errors: 0, Skipped: 0 Also upped a new UI image after manual testing.
          Hide
          stack added a comment -

          I tried it. We probably should not bother showing dead servers if none to show but otherwise looks good Harsh. This will do for now. Thanks for the patch. Applied to TRUNK.

          Show
          stack added a comment - I tried it. We probably should not bother showing dead servers if none to show but otherwise looks good Harsh. This will do for now. Thanks for the patch. Applied to TRUNK.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2208 (See https://builds.apache.org/job/HBase-TRUNK/2208/)
          HBASE-4359 Show dead RegionServer names in the HMaster info page

          stack :
          Files :

          • /hbase/trunk/CHANGES.txt
          • /hbase/trunk/src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterStatusServlet.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterStatusServlet.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2208 (See https://builds.apache.org/job/HBase-TRUNK/2208/ ) HBASE-4359 Show dead RegionServer names in the HMaster info page stack : Files : /hbase/trunk/CHANGES.txt /hbase/trunk/src/main/jamon/org/apache/hbase/tmpl/master/MasterStatusTmpl.jamon /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterStatusServlet.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/master/TestMasterStatusServlet.java

            People

            • Assignee:
              Harsh J
              Reporter:
              Harsh J
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development