Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-4297

TableMapReduceUtil overwrites user supplied options

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • 0.90.4
    • 0.90.5
    • mapreduce
    • None
    • Reviewed

    Description

      Job configuration is overwritten by hbase-default and hbase-site in TableMapReduceUtil.initTable(Mapper|Reducer)Job, causing unexpected behavior in the following code:

      Configuration conf = HBaseConfiguration.create();
      
      // change keyvalue size
      conf.setInt("hbase.client.keyvalue.maxsize", 20971520);
      
      Job job = new Job(conf, ...);
      
      TableMapReduceUtil.initTableMapperJob(...);
      
      // the job doesn't have the option changed, uses it from hbase-site or hbase-default
      job.submit();
      

      Although in this case it could be fixed by moving the set() after initTableMapperJob(), in case where user wants to change some option using GenericOptionsParser and -D this is impossible, making this cool feature useless.

      In the 0.20.x era this code behaved as expected. The solution of this problem should be that we don't overwrite the options, but just read them if they are missing.

      Attachments

        1. HBASE-4297.patch
          3 kB
          Jan Lukavsky

        Activity

          People

            Unassigned Unassigned
            je.ik Jan Lukavsky
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: