HBase
  1. HBase
  2. HBASE-4276

AssignmentManager debug logs should be at INFO level for META/ROOT regions

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.90.4
    • Fix Version/s: 0.90.5
    • Component/s: master
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The master debug logs are quite verbose, so people don't usually have them all on. But, when trying to debug why a cluster's in a bad state due to META or ROOT issues, it's really helpful to have this info. So, for any transition info for these important regions, we should always log details at INFO level.

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #2163 (See https://builds.apache.org/job/HBase-TRUNK/2163/)
        HBASE-4276 AssignmentManager debug logs should be at INFO level for META/ROOT regions.
        Revert previous commit of HBASE-4276

        Realized after committing that the conditions should check
        isMetaTable || isRootRegion, not just isMetaTable. Will recommit
        a fixed version.
        Previous commit purported to revert HBASE-4276, but accidentally reverted HBASE-4293.

        This commit re-applies HBASE-4293. The next commit will actually revert HBASE-4276
        Revert previous commit of HBASE-4276

        Realized after committing that the conditions should check
        isMetaTable || isRootRegion, not just isMetaTable. Will recommit
        a fixed version.
        HBASE-4276 AssignmentManager debug logs should be at INFO level for META/ROOT regions.

        todd :
        Files :

        • /hbase/trunk/CHANGES.txt
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java

        todd :
        Files :

        • /hbase/trunk/CHANGES.txt
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java

        todd :
        Files :

        • /hbase/trunk/CHANGES.txt
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java

        todd :
        Files :

        • /hbase/trunk/CHANGES.txt
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java

        todd :
        Files :

        • /hbase/trunk/CHANGES.txt
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java
        • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #2163 (See https://builds.apache.org/job/HBase-TRUNK/2163/ ) HBASE-4276 AssignmentManager debug logs should be at INFO level for META/ROOT regions. Revert previous commit of HBASE-4276 Realized after committing that the conditions should check isMetaTable || isRootRegion, not just isMetaTable. Will recommit a fixed version. Previous commit purported to revert HBASE-4276 , but accidentally reverted HBASE-4293 . This commit re-applies HBASE-4293 . The next commit will actually revert HBASE-4276 Revert previous commit of HBASE-4276 Realized after committing that the conditions should check isMetaTable || isRootRegion, not just isMetaTable. Will recommit a fixed version. HBASE-4276 AssignmentManager debug logs should be at INFO level for META/ROOT regions. todd : Files : /hbase/trunk/CHANGES.txt /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java todd : Files : /hbase/trunk/CHANGES.txt /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java todd : Files : /hbase/trunk/CHANGES.txt /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java todd : Files : /hbase/trunk/CHANGES.txt /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/ServerShutdownHandler.java todd : Files : /hbase/trunk/CHANGES.txt /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/AssignmentManager.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/handler/OpenedRegionHandler.java
        Hide
        Todd Lipcon added a comment -

        Also committed to branch.

        Show
        Todd Lipcon added a comment - Also committed to branch.
        Hide
        Todd Lipcon added a comment -

        Committed to trunk with the fix as described above

        Show
        Todd Lipcon added a comment - Committed to trunk with the fix as described above
        Hide
        Todd Lipcon added a comment -

        I committed this, then realized I made the mistake of only checking for isMetaRegion, and didn't do the same for ROOT. I reverted the commit. Here's an improved patch.

        Show
        Todd Lipcon added a comment - I committed this, then realized I made the mistake of only checking for isMetaRegion, and didn't do the same for ROOT. I reverted the commit. Here's an improved patch.
        Hide
        stack added a comment -

        +1

        Show
        stack added a comment - +1

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development