Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-4225

NoSuchColumnFamilyException in multi doesn't say which family is bad

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • 0.90.4
    • 0.90.5
    • None
    • None
    • Reviewed
    • Created a new class OperationStatus that wraps OperationStatusCode and an exception message, most of the patch consists of the former replacing the latter.

    Description

      It's kind of a dumb one, in HRegion.doMiniBatchPut we do:

      LOG.warn("No such column family in batch put", nscf);
      batchOp.retCodes[lastIndexExclusive] = OperationStatusCode.BAD_FAMILY;
      

      So we lose the family here, all we know is there's a bad one, that's what's in HRS.multi:

      } else if (code == OperationStatusCode.BAD_FAMILY) {
        result = new NoSuchColumnFamilyException();
      

      We can't just throw the exception like that, we need to say which one is bad even if it requires testing all passed MultiActions.

      Attachments

        1. HBASE-4225_0.90.patch
          10 kB
          ramkrishna.s.vasudevan
        2. HBASE-4225_0.90_3.patch
          12 kB
          ramkrishna.s.vasudevan
        3. HBASE-4225_0.90_2.patch
          12 kB
          ramkrishna.s.vasudevan
        4. HBASE-4225_0.90_1.patch
          10 kB
          ramkrishna.s.vasudevan
        5. 4225.trunk
          11 kB
          Ted Yu

        Activity

          People

            ram_krish ramkrishna.s.vasudevan
            jdcryans Jean-Daniel Cryans
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: