HBase
  1. HBase
  2. HBASE-4113

Add createAsync and splits by start and end key to the shell

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 0.92.0
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    1. HBASE-4113-v2.patch
      6 kB
      Lars George
    2. HBASE-4113.patch
      4 kB
      Lars George

      Activity

      Hide
      Lars George added a comment -

      The patch adds two things:

      • Support for create_async, which uses the async creation
      • Support for create with start and end key, plus number of regions

      Note: The latter is missing from the async call, so we should create a new issue to support that too. Internally it already calls the async anyways, it is just missing the split computation - which could be done from the client side using the public Bytes methods. But then again, why do we have a sync create with that signature? I vote for both or none.

      Show
      Lars George added a comment - The patch adds two things: Support for create_async, which uses the async creation Support for create with start and end key, plus number of regions Note: The latter is missing from the async call, so we should create a new issue to support that too. Internally it already calls the async anyways, it is just missing the split computation - which could be done from the client side using the public Bytes methods. But then again, why do we have a sync create with that signature? I vote for both or none.
      Hide
      Lars George added a comment -

      If we have the latter with async then we can adjust the create_async to have the same help text and support for all split types.

      Show
      Lars George added a comment - If we have the latter with async then we can adjust the create_async to have the same help text and support for all split types.
      Hide
      Lars George added a comment -

      Adds missing create_async.rb

      Show
      Lars George added a comment - Adds missing create_async.rb
      Hide
      Lars George added a comment -

      Another comment, I was pondering if we add async support differently, i.e., by adding a

      { OPTIONS => 'async=true'}

      , or

      { ASYNC => true }

      of some sort. This keeps the number of commands the same, but is more 'cumbersome' to use. I think the "_async" is OK, no?

      Show
      Lars George added a comment - Another comment, I was pondering if we add async support differently, i.e., by adding a { OPTIONS => 'async=true'} , or { ASYNC => true } of some sort. This keeps the number of commands the same, but is more 'cumbersome' to use. I think the "_async" is OK, no?
      Hide
      Ted Yu added a comment -

      +1 on patch version 2.

      Show
      Ted Yu added a comment - +1 on patch version 2.
      Hide
      stack added a comment -

      +1 on commit, if it works (smile). Nice one.

      Show
      stack added a comment - +1 on commit, if it works (smile). Nice one.
      Hide
      Lars Hofhansl added a comment -

      Aaaand?
      Ready for commit? (I assume the patch will be horribly outdated by now).

      Show
      Lars Hofhansl added a comment - Aaaand? Ready for commit? (I assume the patch will be horribly outdated by now).
      Hide
      Lars Hofhansl added a comment -

      Moving out of 0.94. Pull back if you feel differently.

      Show
      Lars Hofhansl added a comment - Moving out of 0.94. Pull back if you feel differently.
      Hide
      stack added a comment -

      Moving out of 0.96; move it back if you disagree.

      LarsG, if you are up for it, try your patch and commit if it works still (you got two +1s on it).

      One thought: Could this issue have been done as an option on create command?

      Thanks.

      Show
      stack added a comment - Moving out of 0.96; move it back if you disagree. LarsG, if you are up for it, try your patch and commit if it works still (you got two +1s on it). One thought: Could this issue have been done as an option on create command? Thanks.

        People

        • Assignee:
          Unassigned
          Reporter:
          Lars George
        • Votes:
          0 Vote for this issue
          Watchers:
          2 Start watching this issue

          Dates

          • Created:
            Updated:

            Development