HBase
  1. HBase
  2. HBASE-4048

[Coprocessors] Support configuration of coprocessor at load time

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.92.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Users should be able to pass configuration options to coprocessors. These options should be applied at load time.

      • For system coprocessors, just use the configuration of the container.
      • Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value> {,}

        ).

      1. HBASE-4048.patch
        34 kB
        Andrew Purtell
      2. HBASE-4048.patch
        31 kB
        Andrew Purtell

        Issue Links

          Activity

          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/984/
          -----------------------------------------------------------

          Review request for hbase.

          Summary
          -------

          Users should be able to pass configuration options to coprocessors. These options should be applied at load time.

          • For system coprocessors, just use the configuration of the container.
          • Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value> {,}

            ).

          This addresses bug HBASE-4048.
          https://issues.apache.org/jira/browse/HBASE-4048

          Diffs


          src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442
          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a
          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a
          src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea
          src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f
          src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c
          src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8
          src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3
          src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1

          Diff: https://reviews.apache.org/r/984/diff

          Testing
          -------

          Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.

          Thanks,

          Andrew

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/984/ ----------------------------------------------------------- Review request for hbase. Summary ------- Users should be able to pass configuration options to coprocessors. These options should be applied at load time. For system coprocessors, just use the configuration of the container. Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value> {,} ). This addresses bug HBASE-4048 . https://issues.apache.org/jira/browse/HBASE-4048 Diffs src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442 src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8 src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3 src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1 Diff: https://reviews.apache.org/r/984/diff Testing ------- Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality. Thanks, Andrew
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/984/
          -----------------------------------------------------------

          (Updated 2011-06-30 21:16:28.392221)

          Review request for hbase.

          Summary (updated)
          -------

          Users should be able to pass configuration options to coprocessors. These options should be applied at load time.

          • For system coprocessors, just use the configuration of the container.
          • Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value> {,}

            ).

          Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.

          This addresses bug HBASE-4048.
          https://issues.apache.org/jira/browse/HBASE-4048

          Diffs


          src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442
          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a
          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a
          src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea
          src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f
          src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c
          src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8
          src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3
          src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1

          Diff: https://reviews.apache.org/r/984/diff

          Testing
          -------

          Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.

          Thanks,

          Andrew

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/984/ ----------------------------------------------------------- (Updated 2011-06-30 21:16:28.392221) Review request for hbase. Summary (updated) ------- Users should be able to pass configuration options to coprocessors. These options should be applied at load time. For system coprocessors, just use the configuration of the container. Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value> {,} ). Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values. This addresses bug HBASE-4048 . https://issues.apache.org/jira/browse/HBASE-4048 Diffs src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442 src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8 src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3 src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1 Diff: https://reviews.apache.org/r/984/diff Testing ------- Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality. Thanks, Andrew
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/984/#review936
          -----------------------------------------------------------

          src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
          <https://reviews.apache.org/r/984/#comment2013>

          Would an abstract class be more appropriate here ?

          src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
          <https://reviews.apache.org/r/984/#comment2012>

          White space.

          • Ted

          On 2011-06-30 21:16:28, Andrew Purtell wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/984/

          -----------------------------------------------------------

          (Updated 2011-06-30 21:16:28)

          Review request for hbase.

          Summary

          -------

          Users should be able to pass configuration options to coprocessors. These options should be applied at load time.

          - For system coprocessors, just use the configuration of the container.

          - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).

          Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.

          This addresses bug HBASE-4048.

          https://issues.apache.org/jira/browse/HBASE-4048

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442

          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a

          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a

          src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea

          src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f

          src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1

          Diff: https://reviews.apache.org/r/984/diff

          Testing

          -------

          Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.

          Thanks,

          Andrew

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/984/#review936 ----------------------------------------------------------- src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java < https://reviews.apache.org/r/984/#comment2013 > Would an abstract class be more appropriate here ? src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java < https://reviews.apache.org/r/984/#comment2012 > White space. Ted On 2011-06-30 21:16:28, Andrew Purtell wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/984/ ----------------------------------------------------------- (Updated 2011-06-30 21:16:28) Review request for hbase. Summary ------- Users should be able to pass configuration options to coprocessors. These options should be applied at load time. - For system coprocessors, just use the configuration of the container. - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}). Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values. This addresses bug HBASE-4048 . https://issues.apache.org/jira/browse/HBASE-4048 Diffs ----- src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442 src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8 src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3 src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1 Diff: https://reviews.apache.org/r/984/diff Testing ------- Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality. Thanks, Andrew
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2011-06-30 21:56:16, Ted Yu wrote:

          > src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java, line 31

          > <https://reviews.apache.org/r/984/diff/1/?file=21839#file21839line31>

          >

          > Would an abstract class be more appropriate here ?

          Because this is an Interface, the compiler will substitute static final values while processing code that references it without generating class files. Isn't that preferable here, given Priority is used equivalently to a C/C++ #define?

          • Andrew

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/984/#review936
          -----------------------------------------------------------

          On 2011-06-30 21:16:28, Andrew Purtell wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/984/

          -----------------------------------------------------------

          (Updated 2011-06-30 21:16:28)

          Review request for hbase.

          Summary

          -------

          Users should be able to pass configuration options to coprocessors. These options should be applied at load time.

          - For system coprocessors, just use the configuration of the container.

          - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).

          Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.

          This addresses bug HBASE-4048.

          https://issues.apache.org/jira/browse/HBASE-4048

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442

          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a

          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a

          src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea

          src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f

          src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1

          Diff: https://reviews.apache.org/r/984/diff

          Testing

          -------

          Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.

          Thanks,

          Andrew

          Show
          jiraposter@reviews.apache.org added a comment - On 2011-06-30 21:56:16, Ted Yu wrote: > src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java, line 31 > < https://reviews.apache.org/r/984/diff/1/?file=21839#file21839line31 > > > Would an abstract class be more appropriate here ? Because this is an Interface, the compiler will substitute static final values while processing code that references it without generating class files. Isn't that preferable here, given Priority is used equivalently to a C/C++ #define? Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/984/#review936 ----------------------------------------------------------- On 2011-06-30 21:16:28, Andrew Purtell wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/984/ ----------------------------------------------------------- (Updated 2011-06-30 21:16:28) Review request for hbase. Summary ------- Users should be able to pass configuration options to coprocessors. These options should be applied at load time. - For system coprocessors, just use the configuration of the container. - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}). Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values. This addresses bug HBASE-4048 . https://issues.apache.org/jira/browse/HBASE-4048 Diffs ----- src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442 src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8 src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3 src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1 Diff: https://reviews.apache.org/r/984/diff Testing ------- Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality. Thanks, Andrew
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/984/#review943
          -----------------------------------------------------------

          src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
          <https://reviews.apache.org/r/984/#comment2019>

          Here they're not declared final.

          I guess the reason of retaining Priority was for compatibility so that Coprocessor.Priority.USER, etc in user code would compile.

          Since 0.92 hasn't been released, we don't need to be bounded by the above.

          Maybe there was other reason.

          • Ted

          On 2011-06-30 21:16:28, Andrew Purtell wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/984/

          -----------------------------------------------------------

          (Updated 2011-06-30 21:16:28)

          Review request for hbase.

          Summary

          -------

          Users should be able to pass configuration options to coprocessors. These options should be applied at load time.

          - For system coprocessors, just use the configuration of the container.

          - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).

          Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.

          This addresses bug HBASE-4048.

          https://issues.apache.org/jira/browse/HBASE-4048

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442

          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a

          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a

          src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea

          src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f

          src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1

          Diff: https://reviews.apache.org/r/984/diff

          Testing

          -------

          Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.

          Thanks,

          Andrew

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/984/#review943 ----------------------------------------------------------- src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java < https://reviews.apache.org/r/984/#comment2019 > Here they're not declared final. I guess the reason of retaining Priority was for compatibility so that Coprocessor.Priority.USER, etc in user code would compile. Since 0.92 hasn't been released, we don't need to be bounded by the above. Maybe there was other reason. Ted On 2011-06-30 21:16:28, Andrew Purtell wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/984/ ----------------------------------------------------------- (Updated 2011-06-30 21:16:28) Review request for hbase. Summary ------- Users should be able to pass configuration options to coprocessors. These options should be applied at load time. - For system coprocessors, just use the configuration of the container. - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}). Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values. This addresses bug HBASE-4048 . https://issues.apache.org/jira/browse/HBASE-4048 Diffs ----- src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442 src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8 src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3 src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1 Diff: https://reviews.apache.org/r/984/diff Testing ------- Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality. Thanks, Andrew
          Hide
          jiraposter@reviews.apache.org added a comment -

          On 2011-07-01 01:28:44, Ted Yu wrote:

          > src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java, line 31

          > <https://reviews.apache.org/r/984/diff/1/?file=21839#file21839line31>

          >

          > Here they're not declared final.

          >

          > I guess the reason of retaining Priority was for compatibility so that Coprocessor.Priority.USER, etc in user code would compile.

          >

          > Since 0.92 hasn't been released, we don't need to be bounded by the above.

          >

          > Maybe there was other reason.

          I guess the reason of retaining Priority was for compatibility so that Coprocessor.Priority.USER, etc in user code would compile.

          This does not make sense to be bound by such considerations until release.

          • Andrew

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/984/#review943
          -----------------------------------------------------------

          On 2011-06-30 21:16:28, Andrew Purtell wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/984/

          -----------------------------------------------------------

          (Updated 2011-06-30 21:16:28)

          Review request for hbase.

          Summary

          -------

          Users should be able to pass configuration options to coprocessors. These options should be applied at load time.

          - For system coprocessors, just use the configuration of the container.

          - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).

          Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.

          This addresses bug HBASE-4048.

          https://issues.apache.org/jira/browse/HBASE-4048

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442

          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a

          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a

          src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea

          src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f

          src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1

          Diff: https://reviews.apache.org/r/984/diff

          Testing

          -------

          Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.

          Thanks,

          Andrew

          Show
          jiraposter@reviews.apache.org added a comment - On 2011-07-01 01:28:44, Ted Yu wrote: > src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java, line 31 > < https://reviews.apache.org/r/984/diff/1/?file=21839#file21839line31 > > > Here they're not declared final. > > I guess the reason of retaining Priority was for compatibility so that Coprocessor.Priority.USER, etc in user code would compile. > > Since 0.92 hasn't been released, we don't need to be bounded by the above. > > Maybe there was other reason. I guess the reason of retaining Priority was for compatibility so that Coprocessor.Priority.USER, etc in user code would compile. This does not make sense to be bound by such considerations until release. Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/984/#review943 ----------------------------------------------------------- On 2011-06-30 21:16:28, Andrew Purtell wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/984/ ----------------------------------------------------------- (Updated 2011-06-30 21:16:28) Review request for hbase. Summary ------- Users should be able to pass configuration options to coprocessors. These options should be applied at load time. - For system coprocessors, just use the configuration of the container. - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}). Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values. This addresses bug HBASE-4048 . https://issues.apache.org/jira/browse/HBASE-4048 Diffs ----- src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442 src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8 src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3 src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1 Diff: https://reviews.apache.org/r/984/diff Testing ------- Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality. Thanks, Andrew
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/984/
          -----------------------------------------------------------

          (Updated 2011-07-01 08:00:54.357860)

          Review request for hbase.

          Changes
          -------

          Fix oversight in not making interface Priority constants final, pointed out by Ted.

          Summary
          -------

          Users should be able to pass configuration options to coprocessors. These options should be applied at load time.

          • For system coprocessors, just use the configuration of the container.
          • Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value> {,}

            ).

          Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.

          This addresses bug HBASE-4048.
          https://issues.apache.org/jira/browse/HBASE-4048

          Diffs (updated)


          src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442
          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a
          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a
          src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea
          src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f
          src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c
          src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8
          src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3
          src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1

          Diff: https://reviews.apache.org/r/984/diff

          Testing
          -------

          Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.

          Thanks,

          Andrew

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/984/ ----------------------------------------------------------- (Updated 2011-07-01 08:00:54.357860) Review request for hbase. Changes ------- Fix oversight in not making interface Priority constants final, pointed out by Ted. Summary ------- Users should be able to pass configuration options to coprocessors. These options should be applied at load time. For system coprocessors, just use the configuration of the container. Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value> {,} ). Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values. This addresses bug HBASE-4048 . https://issues.apache.org/jira/browse/HBASE-4048 Diffs (updated) src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442 src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8 src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3 src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1 Diff: https://reviews.apache.org/r/984/diff Testing ------- Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality. Thanks, Andrew
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/984/#review951
          -----------------------------------------------------------

          src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
          <https://reviews.apache.org/r/984/#comment2024>

          Instead of an interface inside an interface, how about lifting the four Priority constants to Coprocessor ?

          • Ted

          On 2011-07-01 08:00:54, Andrew Purtell wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/984/

          -----------------------------------------------------------

          (Updated 2011-07-01 08:00:54)

          Review request for hbase.

          Summary

          -------

          Users should be able to pass configuration options to coprocessors. These options should be applied at load time.

          - For system coprocessors, just use the configuration of the container.

          - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).

          Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.

          This addresses bug HBASE-4048.

          https://issues.apache.org/jira/browse/HBASE-4048

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442

          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a

          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a

          src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea

          src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f

          src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1

          Diff: https://reviews.apache.org/r/984/diff

          Testing

          -------

          Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.

          Thanks,

          Andrew

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/984/#review951 ----------------------------------------------------------- src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java < https://reviews.apache.org/r/984/#comment2024 > Instead of an interface inside an interface, how about lifting the four Priority constants to Coprocessor ? Ted On 2011-07-01 08:00:54, Andrew Purtell wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/984/ ----------------------------------------------------------- (Updated 2011-07-01 08:00:54) Review request for hbase. Summary ------- Users should be able to pass configuration options to coprocessors. These options should be applied at load time. - For system coprocessors, just use the configuration of the container. - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}). Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values. This addresses bug HBASE-4048 . https://issues.apache.org/jira/browse/HBASE-4048 Diffs ----- src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442 src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java a98117f src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8 src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3 src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1 Diff: https://reviews.apache.org/r/984/diff Testing ------- Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality. Thanks, Andrew
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/984/
          -----------------------------------------------------------

          (Updated 2011-07-01 17:19:11.368248)

          Review request for hbase.

          Changes
          -------

          Lift the four Priority constants to Coprocessor.

          Clean up extraneous whitespace.

          Summary
          -------

          Users should be able to pass configuration options to coprocessors. These options should be applied at load time.

          • For system coprocessors, just use the configuration of the container.
          • Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value> {,}

            ).

          Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.

          This addresses bug HBASE-4048.
          https://issues.apache.org/jira/browse/HBASE-4048

          Diffs (updated)


          src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442
          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a
          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a
          src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea
          src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java 9c4916f
          src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c
          src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8
          src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3
          src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java 0435326
          src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1

          Diff: https://reviews.apache.org/r/984/diff

          Testing
          -------

          Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.

          Thanks,

          Andrew

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/984/ ----------------------------------------------------------- (Updated 2011-07-01 17:19:11.368248) Review request for hbase. Changes ------- Lift the four Priority constants to Coprocessor. Clean up extraneous whitespace. Summary ------- Users should be able to pass configuration options to coprocessors. These options should be applied at load time. For system coprocessors, just use the configuration of the container. Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value> {,} ). Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values. This addresses bug HBASE-4048 . https://issues.apache.org/jira/browse/HBASE-4048 Diffs (updated) src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442 src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java 9c4916f src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8 src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3 src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java 0435326 src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1 Diff: https://reviews.apache.org/r/984/diff Testing ------- Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality. Thanks, Andrew
          Hide
          jiraposter@reviews.apache.org added a comment -

          -----------------------------------------------------------
          This is an automatically generated e-mail. To reply, visit:
          https://reviews.apache.org/r/984/#review953
          -----------------------------------------------------------

          Ship it!

          • Ted

          On 2011-07-01 17:19:11, Andrew Purtell wrote:

          -----------------------------------------------------------

          This is an automatically generated e-mail. To reply, visit:

          https://reviews.apache.org/r/984/

          -----------------------------------------------------------

          (Updated 2011-07-01 17:19:11)

          Review request for hbase.

          Summary

          -------

          Users should be able to pass configuration options to coprocessors. These options should be applied at load time.

          - For system coprocessors, just use the configuration of the container.

          - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}).

          Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values.

          This addresses bug HBASE-4048.

          https://issues.apache.org/jira/browse/HBASE-4048

          Diffs

          -----

          src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442

          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a

          src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a

          src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea

          src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java 9c4916f

          src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java 0435326

          src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1

          Diff: https://reviews.apache.org/r/984/diff

          Testing

          -------

          Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality.

          Thanks,

          Andrew

          Show
          jiraposter@reviews.apache.org added a comment - ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/984/#review953 ----------------------------------------------------------- Ship it! Ted On 2011-07-01 17:19:11, Andrew Purtell wrote: ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/984/ ----------------------------------------------------------- (Updated 2011-07-01 17:19:11) Review request for hbase. Summary ------- Users should be able to pass configuration options to coprocessors. These options should be applied at load time. - For system coprocessors, just use the configuration of the container. - Extend table coprocessor load specification to allow arbitrary key-value pairs at the end (<key>=<value>{,}). Also fixes the outstanding issue where coprocessor priority is supposed to be an integer range but is constrained by the Coprocessor.Priority enum to 4 values. This addresses bug HBASE-4048 . https://issues.apache.org/jira/browse/HBASE-4048 Diffs ----- src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java c2ea442 src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java ac5387a src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java 5bae05a src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java 4800bea src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java 9c4916f src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java 796742c src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java 58a09f8 src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 969b1f3 src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java 0435326 src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java 0cdf7d1 Diff: https://reviews.apache.org/r/984/diff Testing ------- Modified o.a.h.h.coprocessor.TestClassLoading to check new functionality. Thanks, Andrew
          Hide
          Andrew Purtell added a comment -

          Final patch after review.

          Show
          Andrew Purtell added a comment - Final patch after review.
          Hide
          Andrew Purtell added a comment -

          Committed. Thanks for the reviews Ted.

          Show
          Andrew Purtell added a comment - Committed. Thanks for the reviews Ted.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #2000 (See https://builds.apache.org/job/HBase-TRUNK/2000/)
          HBASE-4048 Support configuration of coprocessor at load time

          apurtell :
          Files :

          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java
          • /hbase/trunk/CHANGES.txt
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java
          • /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java
          • /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
          Show
          Hudson added a comment - Integrated in HBase-TRUNK #2000 (See https://builds.apache.org/job/HBase-TRUNK/2000/ ) HBASE-4048 Support configuration of coprocessor at load time apurtell : Files : /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/RegionCoprocessorHost.java /hbase/trunk/CHANGES.txt /hbase/trunk/src/main/java/org/apache/hadoop/hbase/master/MasterCoprocessorHost.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestClassLoading.java /hbase/trunk/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorEnvironment.java /hbase/trunk/src/main/java/org/apache/hadoop/hbase/coprocessor/Coprocessor.java
          Hide
          Jason Rutherglen added a comment -

          Is there documentation on how to use this API? It looks like the main entry point is represented in this sample code?

          htd.setValue("COPROCESSOR$2", jarFileOnHDFS2.toString() + "|" + cpName2 +
          +"|" + Coprocessor.PRIORITY_USER + "|k1=v1,k2=v2,k3=v3");
          

          Where pipe is used as a separator? Looks like pipe is required?

          Show
          Jason Rutherglen added a comment - Is there documentation on how to use this API? It looks like the main entry point is represented in this sample code? htd.setValue( "COPROCESSOR$2" , jarFileOnHDFS2.toString() + "|" + cpName2 + + "|" + Coprocessor.PRIORITY_USER + "|k1=v1,k2=v2,k3=v3" ); Where pipe is used as a separator? Looks like pipe is required?

            People

            • Assignee:
              Andrew Purtell
              Reporter:
              Andrew Purtell
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development