[HBASE-3925] Make Shell's -d and debug cmd behave the same

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 0.90.3, 0.90.7, 0.92.2, 0.94.3, 0.98.0, 0.95.2
• Fix Version/s: 0.95.0
• Component/s: shell
• Labels: patch
• Hadoop Flags: Reviewed
• Assignee: Liang Xie
• Reporter: Lars George
• Created: 26/May/11 11:55
• Updated: 23/Sep/13 18:44
• Resolved: 28/Oct/12 01:37

Description

The -d option switches log4j to DEBUG and leaves the backtrace level at the default. When using the supplied debug command we only switch the backtrace, but I would think this also should set the log4j levels:

# Debugging method
def debug
  if @shell.debug
    @shell.debug = false
    conf.back_trace_limit = 0
  else
    @shell.debug = true
    conf.back_trace_limit = 100
  end
  debug?
end

could be something like

# Debugging method
def debug
  if @shell.debug
    @shell.debug = false
    conf.back_trace_limit = 0
    log_level = org.apache.log4j.Level::ERROR
  else
    @shell.debug = true
    conf.back_trace_limit = 100
    log_level = org.apache.log4j.Level::DEBUG
  end
  org.apache.log4j.Logger.getLogger("org.apache.zookeeper").setLevel(log_level)
  org.apache.log4j.Logger.getLogger("org.apache.hadoop.hbase").setLevel(log_level)
  debug?
end