[HBASE-3861] MiniZooKeeperCluster.startup() should refer to hbase.zookeeper.property.maxClientCnxns

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.90.3
• Hadoop Flags: Reviewed
• Assignee: Eugene Joseph Koontz
• Reporter: Eugene Joseph Koontz
• Created: 05/May/11 23:01
• Updated: 12/Jun/22 18:48
• Resolved: 05/Sep/12 17:58

Description

Currently the number of the client connections is hard-wired to 1000:

        standaloneServerFactory = new NIOServerCnxnFactory();
        standaloneServerFactory.configure(new InetSocketAddress(clientPort),1000);
      } catch (BindException e) {
 

This should be set according to the test environment's hbase configuration. The property in
question is : hbase.zookeeper.property.maxClientCnxns.

Currently some tests such as org.apache.hadoop.hbase.client.TestHCM fail because the number of connections used by the HBase client exceeds 1000.

Recently MAX_CACHED_HBASE_INSTANCES increased from 31 to 2000 on 0.90 branch:

http://svn.apache.org/viewvc/hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java?p2=%2Fhbase%2Fbranches%2F0.90%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhadoop%2Fhbase%2Fclient%2FHConnectionManager.java&p1=%2Fhbase%2Fbranches%2F0.90%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhadoop%2Fhbase%2Fclient%2FHConnectionManager.java&r1=1096818&r2=1096817&view=diff&pathrev=1096818

and correspondingly the hbase config on the Zookeeper server-side also increased in hbase-default.xml:

http://svn.apache.org/viewvc/hbase/branches/0.90/src/main/resources/hbase-default.xml?p2=%2Fhbase%2Fbranches%2F0.90%2Fsrc%2Fmain%2Fresources%2Fhbase-default.xml&p1=%2Fhbase%2Fbranches%2F0.90%2Fsrc%2Fmain%2Fresources%2Fhbase-default.xml&r1=1091594&r2=1091593&view=diff&pathrev=1091594

So if MiniZKCluster looks at this setting, the test won't have this failure.

Issue Links

• is related to: HBASE-3773 Set ZK max connections much higher in 0.90
• is related to: HBASE-3777 Redefine Identity Of HBase Configuration