Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-3861

MiniZooKeeperCluster.startup() should refer to hbase.zookeeper.property.maxClientCnxns

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.90.3
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently the number of the client connections is hard-wired to 1000:

              standaloneServerFactory = new NIOServerCnxnFactory();
              standaloneServerFactory.configure(new InetSocketAddress(clientPort),1000);
            } catch (BindException e) {
       
      

      This should be set according to the test environment's hbase configuration. The property in
      question is : hbase.zookeeper.property.maxClientCnxns.

      Currently some tests such as org.apache.hadoop.hbase.client.TestHCM fail because the number of connections used by the HBase client exceeds 1000.

      Recently MAX_CACHED_HBASE_INSTANCES increased from 31 to 2000 on 0.90 branch:

      http://svn.apache.org/viewvc/hbase/branches/0.90/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java?p2=%2Fhbase%2Fbranches%2F0.90%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhadoop%2Fhbase%2Fclient%2FHConnectionManager.java&p1=%2Fhbase%2Fbranches%2F0.90%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fhadoop%2Fhbase%2Fclient%2FHConnectionManager.java&r1=1096818&r2=1096817&view=diff&pathrev=1096818

      and correspondingly the hbase config on the Zookeeper server-side also increased in hbase-default.xml:

      http://svn.apache.org/viewvc/hbase/branches/0.90/src/main/resources/hbase-default.xml?p2=%2Fhbase%2Fbranches%2F0.90%2Fsrc%2Fmain%2Fresources%2Fhbase-default.xml&p1=%2Fhbase%2Fbranches%2F0.90%2Fsrc%2Fmain%2Fresources%2Fhbase-default.xml&r1=1091594&r2=1091593&view=diff&pathrev=1091594

      So if MiniZKCluster looks at this setting, the test won't have this failure.

        Attachments

        1. HBASE-3861.patch
          3 kB
          Eugene Koontz
        2. HBASE-3861.patch
          3 kB
          Eugene Koontz

          Issue Links

            Activity

              People

              • Assignee:
                ekoontz Eugene Koontz
                Reporter:
                ekoontz Eugene Koontz
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 1h
                  1h
                  Remaining:
                  Remaining Estimate - 1h
                  1h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified