[HBASE-3860] HLog shouldn't create a new HBC when rolling

• Type: Improvement
• Status: Closed
• Priority: Critical
• Resolution: Fixed
• Affects Version/s: 0.90.2
• Fix Version/s: 0.90.3
• Assignee: Jean-Daniel Cryans
• Reporter: Jean-Daniel Cryans
• Created: 05/May/11 22:35
• Updated: 20/Nov/15 12:41
• Resolved: 05/May/11 22:49

Description

HBASE-2059 added this change in HLog.rollWriter:

this.writer = createWriter(fs, newPath, new HBaseConfiguration(conf));

Which has since become:

HLog.Writer nextWriter = this.createWriterInstance(fs, newPath,
  HBaseConfiguration.create(conf));

It's unclear to me why it needs to do that, but it bite us today because we swapped jars under a running hbase with:

2011-05-05 12:06:12,876 FATAL org.apache.hadoop.conf.Configuration: error parsing conf file: java.util.zip.ZipException: invalid stored block lengths
2011-05-05 12:06:12,877 ERROR org.apache.hadoop.hbase.regionserver.LogRoller: Log rolling failed
java.lang.RuntimeException: java.util.zip.ZipException: invalid stored block lengths
at org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:1352)
at org.apache.hadoop.conf.Configuration.loadResources(Configuration.java:1227)
at org.apache.hadoop.conf.Configuration.getProps(Configuration.java:1156)
at org.apache.hadoop.conf.Configuration.get(Configuration.java:427)
at org.apache.hadoop.hbase.HBaseConfiguration.checkDefaultsVersion(HBaseConfiguration.java:63)
at org.apache.hadoop.hbase.HBaseConfiguration.addHbaseResources(HBaseConfiguration.java:89)
at org.apache.hadoop.hbase.HBaseConfiguration.create(HBaseConfiguration.java:100)
at org.apache.hadoop.hbase.HBaseConfiguration.create(HBaseConfiguration.java:110)
at org.apache.hadoop.hbase.regionserver.wal.HLog.rollWriter(HLog.java:485)
at org.apache.hadoop.hbase.regionserver.LogRoller.run(LogRoller.java:94)
Caused by: java.util.zip.ZipException: invalid stored block lengths
at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:147)
at java.util.zip.InflaterInputStream.read(InflaterInputStream.java:105)
at java.io.FilterInputStream.read(FilterInputStream.java:66)
at com.sun.org.apache.xerces.internal.impl.XMLEntityManager$RewindableInputStream.read(XMLEntityManager.java:2932)
at com.sun.org.apache.xerces.internal.impl.XMLEntityManager.setupCurrentEntity(XMLEntityManager.java:704)
at com.sun.org.apache.xerces.internal.impl.XMLVersionDetector.determineDocVersion(XMLVersionDetector.java:186)
at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:772)
at com.sun.org.apache.xerces.internal.parsers.XML11Configuration.parse(XML11Configuration.java:737)
at com.sun.org.apache.xerces.internal.parsers.XMLParser.parse(XMLParser.java:119)
at com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:235)
at com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:284)
at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:180)
at org.apache.hadoop.conf.Configuration.loadResource(Configuration.java:1266)
... 9 more