HBase
  1. HBase
  2. HBASE-3794

TestRpcMetrics fails on machine where region server is running

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.90.2
    • Fix Version/s: 0.90.3
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Since whole test suite takes over an hour to run, I ran them on Linux where region server is running.

      Here is the consistent TestRpcMetrics failure I saw:

      Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.196 sec <<< FAILURE!
      testCustomMetrics(org.apache.hadoop.hbase.regionserver.TestRpcMetrics)  Time elapsed: 0.079 sec  <<< ERROR!
      java.net.BindException: Problem binding to /10.202.50.107:60020 : Address already in use
              at org.apache.hadoop.hbase.ipc.HBaseServer.bind(HBaseServer.java:216)
              at org.apache.hadoop.hbase.ipc.HBaseServer$Listener.<init>(HBaseServer.java:283)
              at org.apache.hadoop.hbase.ipc.HBaseServer.<init>(HBaseServer.java:1189)
              at org.apache.hadoop.hbase.ipc.WritableRpcEngine$Server.<init>(WritableRpcEngine.java:266)
              at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getServer(WritableRpcEngine.java:233)
              at org.apache.hadoop.hbase.ipc.WritableRpcEngine.getServer(WritableRpcEngine.java:46)
              at org.apache.hadoop.hbase.ipc.HBaseRPC.getServer(HBaseRPC.java:379)
              at org.apache.hadoop.hbase.ipc.HBaseRPC.getServer(HBaseRPC.java:368)
              at org.apache.hadoop.hbase.regionserver.HRegionServer.<init>(HRegionServer.java:336)
              at org.apache.hadoop.hbase.regionserver.TestRpcMetrics$TestRegionServer.<init>(TestRpcMetrics.java:58)
              at org.apache.hadoop.hbase.regionserver.TestRpcMetrics.testCustomMetrics(TestRpcMetrics.java:119)
      
      1. HBASE-3794.patch
        0.9 kB
        Alex Newman

        Activity

        Ted Yu created issue -
        Alex Newman made changes -
        Field Original Value New Value
        Assignee Alex Newman [ posix4e ]
        Hide
        Alex Newman added a comment -

        Do we already have infrastructure to do?

        + Random random = new Random();
        + TEST_UTIL.getConfiguration().setInt("hbase.regionserver.port",
        + 8080 + random.nextInt(5000));

        Show
        Alex Newman added a comment - Do we already have infrastructure to do? + Random random = new Random(); + TEST_UTIL.getConfiguration().setInt("hbase.regionserver.port", + 8080 + random.nextInt(5000));
        Alex Newman made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Todd Lipcon added a comment -

        Why not set RS port to 0 and use whatever ephemeral port it picks?

        Show
        Todd Lipcon added a comment - Why not set RS port to 0 and use whatever ephemeral port it picks?
        Alex Newman made changes -
        Status In Progress [ 3 ] Patch Available [ 10002 ]
        Alex Newman made changes -
        Attachment HBASE-3794.patch [ 12477017 ]
        Hide
        Alex Newman added a comment -

        Agreed. Hooray 1 line patches.

        Show
        Alex Newman added a comment - Agreed. Hooray 1 line patches.
        Hide
        stack added a comment -

        Committed branch and trunk. Thanks for the patch Alex.

        Show
        stack added a comment - Committed branch and trunk. Thanks for the patch Alex.
        stack made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Fix Version/s 0.90.3 [ 12316313 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #1888 (See https://builds.apache.org/hudson/job/HBase-TRUNK/1888/)

        Show
        Hudson added a comment - Integrated in HBase-TRUNK #1888 (See https://builds.apache.org/hudson/job/HBase-TRUNK/1888/ )
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #1976 (See https://builds.apache.org/job/HBase-TRUNK/1976/)

        Show
        Hudson added a comment - Integrated in HBase-TRUNK #1976 (See https://builds.apache.org/job/HBase-TRUNK/1976/ )

          People

          • Assignee:
            Alex Newman
            Reporter:
            Ted Yu
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development