HBase
  1. HBase
  2. HBASE-3737

HTable - delete(List<Delete>) doesn't use writebuffer

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      I just realized that htable.delete(List<Delete>) doesn't use the writebuffer and processes the list immediately, but htable.put(List<Put>) does use the writebuffer (i.e., send when filled). Likewise, htable.delete(Delete) sends immediately.

      Out of sheer curiosity, why? With the 'batch' methods now in place, it seems like it would be consistent for 'delete' and 'put' to use the writebuffer (assuming it is expanded to hold more than Puts), whereas 'batch' methods process immediately.

      This isn't a huge issue, but it does seem a little inconsistent.

        Activity

        Hide
        Lars Hofhansl added a comment -

        This is still the case in trunk.

        Also looking at the Delete(List<Delete>) code, the passed lists gets modified and will contain those Deletes that failed to be executed. The client presumably has to check and retry. I doubt anybody is doing that.

        Put(List<Put>) is similar (but worse IMHO). The call to the Put method happily returns even when there are left over Puts in the write buffer.

        Show
        Lars Hofhansl added a comment - This is still the case in trunk. Also looking at the Delete(List<Delete>) code, the passed lists gets modified and will contain those Deletes that failed to be executed. The client presumably has to check and retry. I doubt anybody is doing that. Put(List<Put>) is similar (but worse IMHO). The call to the Put method happily returns even when there are left over Puts in the write buffer.
        Doug Meil created issue -

          People

          • Assignee:
            Unassigned
            Reporter:
            Doug Meil
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development