HBase
  1. HBase
  2. HBASE-3678

Add Eclipse-based Apache Formatter to HBase Wiki

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.92.0
    • Component/s: None
    • Labels:
      None

      Description

      Currently, on http://wiki.apache.org/hadoop/Hbase/HowToContribute , we tell the user to follow Sun's code conventions and then add a couple things. For lazy people like myself, it would be much easier to just tell us to import an Apache formatter into your Eclipse project and not worry about it.

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #192 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/192/)
        HBASE-5691 and HBASE-3678 New standard HBase code formatter AND Add Eclipse-based Apache Formatter to HBase Wiki (Revision 1390028)
        HBASE-5691 and HBASE-3678 New standard HBase code formatter AND Add Eclipse-based Apache Formatter to HBase Wiki (Revision 1390026)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/docbkx/developer.xml

        stack :
        Files :

        • /hbase/trunk/dev-support/hbase_eclipse_formatter.xml
        • /hbase/trunk/src/docbkx/developer.xml
        • /hbase/trunk/src/docbkx/troubleshooting.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK-on-Hadoop-2.0.0 #192 (See https://builds.apache.org/job/HBase-TRUNK-on-Hadoop-2.0.0/192/ ) HBASE-5691 and HBASE-3678 New standard HBase code formatter AND Add Eclipse-based Apache Formatter to HBase Wiki (Revision 1390028) HBASE-5691 and HBASE-3678 New standard HBase code formatter AND Add Eclipse-based Apache Formatter to HBase Wiki (Revision 1390026) Result = FAILURE stack : Files : /hbase/trunk/src/docbkx/developer.xml stack : Files : /hbase/trunk/dev-support/hbase_eclipse_formatter.xml /hbase/trunk/src/docbkx/developer.xml /hbase/trunk/src/docbkx/troubleshooting.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #3377 (See https://builds.apache.org/job/HBase-TRUNK/3377/)
        HBASE-5691 and HBASE-3678 New standard HBase code formatter AND Add Eclipse-based Apache Formatter to HBase Wiki (Revision 1390028)
        HBASE-5691 and HBASE-3678 New standard HBase code formatter AND Add Eclipse-based Apache Formatter to HBase Wiki (Revision 1390026)

        Result = FAILURE
        stack :
        Files :

        • /hbase/trunk/src/docbkx/developer.xml

        stack :
        Files :

        • /hbase/trunk/dev-support/hbase_eclipse_formatter.xml
        • /hbase/trunk/src/docbkx/developer.xml
        • /hbase/trunk/src/docbkx/troubleshooting.xml
        Show
        Hudson added a comment - Integrated in HBase-TRUNK #3377 (See https://builds.apache.org/job/HBase-TRUNK/3377/ ) HBASE-5691 and HBASE-3678 New standard HBase code formatter AND Add Eclipse-based Apache Formatter to HBase Wiki (Revision 1390028) HBASE-5691 and HBASE-3678 New standard HBase code formatter AND Add Eclipse-based Apache Formatter to HBase Wiki (Revision 1390026) Result = FAILURE stack : Files : /hbase/trunk/src/docbkx/developer.xml stack : Files : /hbase/trunk/dev-support/hbase_eclipse_formatter.xml /hbase/trunk/src/docbkx/developer.xml /hbase/trunk/src/docbkx/troubleshooting.xml
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #1858 (See https://hudson.apache.org/hudson/job/HBase-TRUNK/1858/)
        Added developer chapter to book; referenced HBASE-3678 and HBase-3754 AND Alex Baranau blog on how to use HBaseTestingUtility
        Added developer chapter to book; referenced HBASE-3678 and HBase-3754 AND Alex Baranau blog on how to use HBaseTestingUtility

        Show
        Hudson added a comment - Integrated in HBase-TRUNK #1858 (See https://hudson.apache.org/hudson/job/HBase-TRUNK/1858/ ) Added developer chapter to book; referenced HBASE-3678 and HBase-3754 AND Alex Baranau blog on how to use HBaseTestingUtility Added developer chapter to book; referenced HBASE-3678 and HBase-3754 AND Alex Baranau blog on how to use HBaseTestingUtility
        Hide
        stack added a comment -

        I just added mention of this issue to the website book into new developer chapter. Resolving now it has pointers from two different doc. locations. Thanks for patch Nicolas.

        Show
        stack added a comment - I just added mention of this issue to the website book into new developer chapter. Resolving now it has pointers from two different doc. locations. Thanks for patch Nicolas.
        Hide
        stack added a comment -

        I added 'If using eclipse, HBASE-3678 has an appropriate formatter attached with instructions on how to load it up into eclipse' to http://wiki.apache.org/hadoop/Hbase/HowToContribute

        Show
        stack added a comment - I added 'If using eclipse, HBASE-3678 has an appropriate formatter attached with instructions on how to load it up into eclipse' to http://wiki.apache.org/hadoop/Hbase/HowToContribute
        Hide
        Nicolas Spiegelberg added a comment -

        1. Go to Eclipse->Preferences...
        2. In Preferences, Go to Java->Code Style->Formatter
        3. Import... <eclipse_formatter_apache.xml>
        4. Click Apply
        5. Still in Preferences, Go to Java->Editor->Save Actions
        6. Check the following:
        a. Perform the selected actions on save
        b. Format source code
        c. Format edited lines

        I don't know if we can make a file to import these preferences without overwriting the user's other preferences, but that would be boss.

        Show
        Nicolas Spiegelberg added a comment - 1. Go to Eclipse->Preferences... 2. In Preferences, Go to Java->Code Style->Formatter 3. Import... <eclipse_formatter_apache.xml> 4. Click Apply 5. Still in Preferences, Go to Java->Editor->Save Actions 6. Check the following: a. Perform the selected actions on save b. Format source code c. Format edited lines I don't know if we can make a file to import these preferences without overwriting the user's other preferences, but that would be boss.

          People

          • Assignee:
            Nicolas Spiegelberg
            Reporter:
            Nicolas Spiegelberg
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development