Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      The existing scanner interface excludes the end key from the result range. If you actually want to do an inclusive scan for some reason, you would currently have to guess at the key immediately after the end key, which is a shoddy solution.

      A new stoprow filter could be created that stops at the end key but also returns it. Then, you could supply an extra parameter to getScanner to say you want an inclusive scan.

      1. inclusive-stop-row.patch
        5 kB
        Bryan Duxbury
      2. inclusive-stop-row-v2.patch
        6 kB
        Bryan Duxbury

        Activity

        Hide
        stack added a comment -

        Committed. Resolving. Thanks for the patch Bryan.

        Show
        stack added a comment - Committed. Resolving. Thanks for the patch Bryan.
        Hide
        Hadoop QA added a comment -

        +1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12370880/inclusive-stop-row-v2.patch
        against trunk revision r600771.

        @author +1. The patch does not contain any @author tags.

        javadoc +1. The javadoc tool did not generate any warning messages.

        javac +1. The applied patch does not generate any new compiler warnings.

        findbugs +1. The patch does not introduce any new Findbugs warnings.

        core tests +1. The patch passed core unit tests.

        contrib tests +1. The patch passed contrib unit tests.

        Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1252/testReport/
        Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1252/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1252/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1252/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12370880/inclusive-stop-row-v2.patch against trunk revision r600771. @author +1. The patch does not contain any @author tags. javadoc +1. The javadoc tool did not generate any warning messages. javac +1. The applied patch does not generate any new compiler warnings. findbugs +1. The patch does not introduce any new Findbugs warnings. core tests +1. The patch passed core unit tests. contrib tests +1. The patch passed contrib unit tests. Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1252/testReport/ Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1252/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1252/artifact/trunk/build/test/checkstyle-errors.html Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1252/console This message is automatically generated.
        Hide
        Bryan Duxbury added a comment -

        Submitting patch.

        Show
        Bryan Duxbury added a comment - Submitting patch.
        Hide
        Bryan Duxbury added a comment -

        Forgot to include modifications to StopRowFilter.java (needed to make an attribute protected instead of private).

        Show
        Bryan Duxbury added a comment - Forgot to include modifications to StopRowFilter.java (needed to make an attribute protected instead of private).
        Hide
        Bryan Duxbury added a comment -

        Adds implementation of InclusiveStopRowFilter and a matching unit test.

        Show
        Bryan Duxbury added a comment - Adds implementation of InclusiveStopRowFilter and a matching unit test.

          People

          • Assignee:
            Unassigned
            Reporter:
            Bryan Duxbury
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development