Details

    • Type: Task Task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.92.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Updated our thrift to 0.6.1. Incompatible change with previous HBase thrift.

      Description

      HBASE-3117 was about updating to 0.5. Moaz Reyad over in that issue is trying to move us to 0.6. Lets move the 0.6 upgrade effort here.

      1. HBASE-3629.patch.zip
        59 kB
        Moaz Reyad
      2. pom.diff
        2 kB
        stack

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #1888 (See https://builds.apache.org/hudson/job/HBase-TRUNK/1888/)

          Show
          Hudson added a comment - Integrated in HBase-TRUNK #1888 (See https://builds.apache.org/hudson/job/HBase-TRUNK/1888/ )
          stack made changes -
          Release Note Updated our thrift to 0.6.1. Incompatible change with previous HBase thrift.
          stack made changes -
          Fix Version/s 0.92.0 [ 12314223 ]
          Hide
          stack added a comment -

          Resolved. Applied to TRUNK (With Lars Francke suggested changes). Thanks for the patch Moaz (its missing apache license off the generated files but I think that ok – until someone tells me otherwise). Thanks for the review Lars.

          Show
          stack added a comment - Resolved. Applied to TRUNK (With Lars Francke suggested changes). Thanks for the patch Moaz (its missing apache license off the generated files but I think that ok – until someone tells me otherwise). Thanks for the review Lars.
          stack made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Hadoop Flags [Reviewed]
          Resolution Fixed [ 1 ]
          Hide
          Lars Francke added a comment -

          Thanks for doing this!

          Please remove the central repository again though. And the finalName entry can be removed as well as it is inherited anyway. Can't alter the patch right now but can do tomorrow if needed. Also the comment about the newer version doesn't apply anymore.

          Show
          Lars Francke added a comment - Thanks for doing this! Please remove the central repository again though. And the finalName entry can be removed as well as it is inherited anyway. Can't alter the patch right now but can do tomorrow if needed. Also the comment about the newer version doesn't apply anymore.
          Moaz Reyad made changes -
          Attachment HBASE-3629.patch.zip [ 12477370 ]
          Hide
          Moaz Reyad added a comment -

          Here is the generated files using thrift 0.6.1 plus the pom changes and little fixes in ThriftServer.java.

          Not sure if the "hadoop-non-releases" is still needed or it can be also removed from pom.

          Show
          Moaz Reyad added a comment - Here is the generated files using thrift 0.6.1 plus the pom changes and little fixes in ThriftServer.java. Not sure if the "hadoop-non-releases" is still needed or it can be also removed from pom.
          stack made changes -
          Attachment pom.diff [ 12477305 ]
          Hide
          stack added a comment -

          Here is patch for our pom. Needs more before can commit; need to regen using thrift 6.x.

          Show
          stack added a comment - Here is patch for our pom. Needs more before can commit; need to regen using thrift 6.x.
          Hide
          Jake Farrell added a comment -

          Libthrift and libfb303 now available in the apache repo (http://repo1.maven.org/maven2)

          <dependency>
          <groupId>org.apache.thrift</groupId>
          <artifactId>libthrift</artifactId>
          <version>[0.6.1,)</version>
          </dependency>

          Show
          Jake Farrell added a comment - Libthrift and libfb303 now available in the apache repo ( http://repo1.maven.org/maven2 ) <dependency> <groupId>org.apache.thrift</groupId> <artifactId>libthrift</artifactId> <version>[0.6.1,)</version> </dependency>
          Hide
          Moaz Reyad added a comment -

          This issue requires a maven repository for Thrift 0.6. I will post a patch once I found a suitable repository.

          Show
          Moaz Reyad added a comment - This issue requires a maven repository for Thrift 0.6. I will post a patch once I found a suitable repository.
          Moaz Reyad made changes -
          Link This issue requires THRIFT-363 [ THRIFT-363 ]
          stack made changes -
          Field Original Value New Value
          Assignee Moaz Reyad [ moazreyad ]
          stack created issue -

            People

            • Assignee:
              Moaz Reyad
              Reporter:
              stack
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development