Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.90.1
    • Fix Version/s: 0.90.2
    • Component/s: None
    • Labels:
      None

      Description

      every now and again in a 0.90.1-2 load run I get a NPE on this line:

      if (bestAnyRegion.memstoreSize.get() > 2 * bestFlushableRegion.memstoreSize.get()) {

      1. HBASE-3613.txt
        1 kB
        ryan rawson
      2. HBASE-3613-v2.txt
        2 kB
        ryan rawson

        Activity

        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #1792 (See https://hudson.apache.org/hudson/job/HBase-TRUNK/1792/)

        Show
        Hudson added a comment - Integrated in HBase-TRUNK #1792 (See https://hudson.apache.org/hudson/job/HBase-TRUNK/1792/ )
        ryan rawson made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Assignee ryan rawson [ ryanobjc ]
        Resolution Fixed [ 1 ]
        Hide
        ryan rawson added a comment -

        my prev patch messed up logging anyways. im going to commit this one.

        Show
        ryan rawson added a comment - my prev patch messed up logging anyways. im going to commit this one.
        ryan rawson made changes -
        Attachment HBASE-3613-v2.txt [ 12473745 ]
        Hide
        ryan rawson added a comment -

        here is an updated patch, that adjusts the logic to be a little more comprehensible.

        Show
        ryan rawson added a comment - here is an updated patch, that adjusts the logic to be a little more comprehensible.
        Hide
        Ted Yu added a comment -

        Please correct the comment: is larger than half of bestAnyRegion memstoreSize

        Show
        Ted Yu added a comment - Please correct the comment: is larger than half of bestAnyRegion memstoreSize
        Hide
        stack added a comment -

        I see. +1 on commit.

        Show
        stack added a comment - I see. +1 on commit.
        Hide
        ryan rawson added a comment -

        Yes, but I also switched what the body did as well

        Show
        ryan rawson added a comment - Yes, but I also switched what the body did as well
        Hide
        stack added a comment -

        Did you swap the content of the 'if' test? You put bestAnyRegion on RHS in your version when its on LHS in what you replace.

        See below:

        
        -      if (bestAnyRegion.memstoreSize.get() > 2 * bestFlushableRegion.memstoreSize.get()) {
        +      HRegion regionToFlush = bestAnyRegion;
        +      // UNLESS.... bestFlushableRegion is twice as large as bestAnyRegion.
        +      if (bestFlushableRegion != null &&
        +          2 * bestFlushableRegion.memstoreSize.get() > bestAnyRegion.memstoreSize.get()) {
        
        
        Show
        stack added a comment - Did you swap the content of the 'if' test? You put bestAnyRegion on RHS in your version when its on LHS in what you replace. See below: - if (bestAnyRegion.memstoreSize.get() > 2 * bestFlushableRegion.memstoreSize.get()) { + HRegion regionToFlush = bestAnyRegion; + // UNLESS.... bestFlushableRegion is twice as large as bestAnyRegion. + if (bestFlushableRegion != null && + 2 * bestFlushableRegion.memstoreSize.get() > bestAnyRegion.memstoreSize.get()) {
        ryan rawson made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 0.90.1 [ 12315548 ]
        Fix Version/s 0.90.2 [ 12316152 ]
        ryan rawson made changes -
        Field Original Value New Value
        Attachment HBASE-3613.txt [ 12473358 ]
        Hide
        ryan rawson added a comment -

        here is a patch that doesn't assume that bestFlushableRegion is not null.

        Show
        ryan rawson added a comment - here is a patch that doesn't assume that bestFlushableRegion is not null.
        ryan rawson created issue -

          People

          • Assignee:
            ryan rawson
            Reporter:
            ryan rawson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development