HBase
  1. HBase
  2. HBASE-3572

memstore lab can leave half inited data structs (bad!)

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.90.1, 0.92.0
    • Fix Version/s: 0.90.2, 0.92.0
    • Component/s: None
    • Labels:
      None

      Description

      in Chunk.init() if new byte[] fails it leaves the Chunk in its uninitialized state, other threads will assume someone else will init it and get stuck in an infinite loop.

        Activity

        Hide
        stack added a comment -

        Patch looks good to me, apply it I'd say, but ain't we hosed if we OOME in first place?

        Show
        stack added a comment - Patch looks good to me, apply it I'd say, but ain't we hosed if we OOME in first place?
        Hide
        ryan rawson added a comment -

        unfortunately you end up with a handler in an infinite loop, and that
        keeps the server from shutting down.

        Show
        ryan rawson added a comment - unfortunately you end up with a handler in an infinite loop, and that keeps the server from shutting down.
        Hide
        Todd Lipcon added a comment -

        +1 lgtm, nice catch

        Show
        Todd Lipcon added a comment - +1 lgtm, nice catch
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #1767 (See https://hudson.apache.org/hudson/job/HBase-TRUNK/1767/)

        Show
        Hudson added a comment - Integrated in HBase-TRUNK #1767 (See https://hudson.apache.org/hudson/job/HBase-TRUNK/1767/ )

          People

          • Assignee:
            ryan rawson
            Reporter:
            ryan rawson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development