Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-3530

Do not start LogSyncer when not in deferred flush mode

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Invalid
    • Affects Version/s: 0.90.0
    • Fix Version/s: None
    • Component/s: regionserver
    • Labels:
      None

      Description

      Currently we always start the LogSyncer thread, even when not necessary because the "deferred flush" is set to false and the sync() is called on every record. We could disable the thread and not have it flush every n secs unnecessarily.

        Activity

        Hide
        streamy Jonathan Gray added a comment -

        In some of the HLog improvements that Dhruba and I have been working on, we've become dependent on the LogSyncer thread. However, this is also still using an HBase-side group commit. Just an FYI (alternative implementations of HLog might be a neat idea, there are lots of different ways to optimize depending on the use case)... don't let it hold you up.

        Expect some patches this week around this stuff. Currently tracking down a pesky race condition.

        Show
        streamy Jonathan Gray added a comment - In some of the HLog improvements that Dhruba and I have been working on, we've become dependent on the LogSyncer thread. However, this is also still using an HBase-side group commit. Just an FYI (alternative implementations of HLog might be a neat idea, there are lots of different ways to optimize depending on the use case)... don't let it hold you up. Expect some patches this week around this stuff. Currently tracking down a pesky race condition.
        Hide
        larsgeorge Lars George added a comment -

        We better wait then and see what you've got. Love the improvements done recently in this area.

        Show
        larsgeorge Lars George added a comment - We better wait then and see what you've got. Love the improvements done recently in this area.
        Hide
        stack stack added a comment -

        Moving out of 0.92. Move it back in if you think differently.

        Show
        stack stack added a comment - Moving out of 0.92. Move it back in if you think differently.
        Hide
        stack stack added a comment -

        Moving out of 0.92. Move it back in if you think differently.

        Show
        stack stack added a comment - Moving out of 0.92. Move it back in if you think differently.
        Hide
        stack stack added a comment -

        No LogSyncer thread anymore. The log writing has been refactored.

        Show
        stack stack added a comment - No LogSyncer thread anymore. The log writing has been refactored.

          People

          • Assignee:
            Unassigned
            Reporter:
            larsgeorge Lars George
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development