HBase
  1. HBase
  2. HBASE-3517

Store build version in hbase-default and verify at runtime

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: 0.90.1
    • Fix Version/s: 0.90.1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This is a second attempt at HBASE-3470 (now reverted) which didn't work properly at MR job submission time since MR unjars the job jar into /tmp when submitting.

      This new JIRA will store the hbase version inside hbase-default, and at runtime verify that the hbase-default matches the version of the code.

      1. hbase-3517.txt
        3 kB
        Todd Lipcon
      2. hbase-3517.txt
        3 kB
        Todd Lipcon

        Issue Links

          Activity

          Hide
          Todd Lipcon added a comment -

          Something like this, maybe?

          Show
          Todd Lipcon added a comment - Something like this, maybe?
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #1739 (See https://hudson.apache.org/hudson/job/HBase-TRUNK/1739/)
          Revert HBASE-3470 since it breaks job submission (HBASE-3517)

          Show
          Hudson added a comment - Integrated in HBase-TRUNK #1739 (See https://hudson.apache.org/hudson/job/HBase-TRUNK/1739/ ) Revert HBASE-3470 since it breaks job submission ( HBASE-3517 )
          Hide
          stack added a comment -

          Does this work?

          +                <echo>Replace in ${project.build.outputDirectory}/hbase-default.xml</echo>
          +                <replace file="${project.build.outputDirectory}/hbase-default.xml"
          +                  token="@@@VERSION@@@" value="${project.version}" />
          

          Where we putting hbase-default.xml into 'target'?

          If it works, +1

          Show
          stack added a comment - Does this work? + <echo>Replace in ${project.build.outputDirectory}/hbase- default .xml</echo> + <replace file= "${project.build.outputDirectory}/hbase- default .xml" + token= "@@@VERSION@@@" value= "${project.version}" /> Where we putting hbase-default.xml into 'target'? If it works, +1
          Hide
          Todd Lipcon added a comment -

          Where we putting hbase-default.xml into 'target'?

          Maven magic - this "phase" runs after the resources are copied, or something. I don't entirely understand but appears to work. I'll double check once more before commit that it works from a clean build.

          Show
          Todd Lipcon added a comment - Where we putting hbase-default.xml into 'target'? Maven magic - this "phase" runs after the resources are copied, or something. I don't entirely understand but appears to work. I'll double check once more before commit that it works from a clean build.
          Hide
          stack added a comment -

          OK. If it works, +1.

          Show
          stack added a comment - OK. If it works, +1.
          Hide
          Todd Lipcon added a comment -

          Updated patch also excludes this option from docs, since it's a private implementation detail and it looked ugly in the docs since the substitution didn't get made.

          Show
          Todd Lipcon added a comment - Updated patch also excludes this option from docs, since it's a private implementation detail and it looked ugly in the docs since the substitution didn't get made.
          Hide
          Hudson added a comment -

          Integrated in HBase-TRUNK #1740 (See https://hudson.apache.org/hudson/job/HBase-TRUNK/1740/)
          HBASE-3517. Store build version in hbase-default.xml and verify at runtime

          Show
          Hudson added a comment - Integrated in HBase-TRUNK #1740 (See https://hudson.apache.org/hudson/job/HBase-TRUNK/1740/ ) HBASE-3517 . Store build version in hbase-default.xml and verify at runtime

            People

            • Assignee:
              Todd Lipcon
              Reporter:
              Todd Lipcon
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development