HBase
  1. HBase
  2. HBASE-3351

ReplicationZookeeper goes to ZK every time a znode is modified

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.90.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      While debugging other issues, I found that ReplicationAdmin.ReplicationStatusTracker is doing a ZK request every time a znode changes. Also reading the replication state shouldn't go to ZK if we already maintain a local variable that's updated with the tracker.

      1. HBASE-3351_3326.patch
        12 kB
        Jean-Daniel Cryans

        Activity

        Hide
        Jean-Daniel Cryans added a comment -

        Attaching a patch that covers both this issue and HBASE-3326 (Replication state's znode should be created else it defaults to false) because they are very intertwined.

        In this patch I fix HBASE-3326 simply by creating the znode and then I add the better tracking of the state znode which had an impact in more user-side classes since they had to provide an Abortable in order to be able to start the tracker in any given situation (before the client wasn't tracking the state znode). In the end, I think this is much better.

        Show
        Jean-Daniel Cryans added a comment - Attaching a patch that covers both this issue and HBASE-3326 (Replication state's znode should be created else it defaults to false) because they are very intertwined. In this patch I fix HBASE-3326 simply by creating the znode and then I add the better tracking of the state znode which had an impact in more user-side classes since they had to provide an Abortable in order to be able to start the tracker in any given situation (before the client wasn't tracking the state znode). In the end, I think this is much better.
        Hide
        stack added a comment -

        +1 Looks reasonable to me J-D.

        Show
        stack added a comment - +1 Looks reasonable to me J-D.
        Hide
        Jean-Daniel Cryans added a comment -

        Committed to branch and trunk, thanks for looking at it Stack.

        Show
        Jean-Daniel Cryans added a comment - Committed to branch and trunk, thanks for looking at it Stack.
        Hide
        Hudson added a comment -

        Integrated in HBase-TRUNK #1697 (See https://hudson.apache.org/hudson/job/HBase-TRUNK/1697/)

        Show
        Hudson added a comment - Integrated in HBase-TRUNK #1697 (See https://hudson.apache.org/hudson/job/HBase-TRUNK/1697/ )

          People

          • Assignee:
            Jean-Daniel Cryans
            Reporter:
            Jean-Daniel Cryans
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development