HBase
  1. HBase
  2. HBASE-3274

Replace all config properties references in code with string constants

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:

      Description

      See HBASE-2721 for details. We have fixed the default values in HBASE-3272 but we should also follow Hadoop to remove all hardcoded strings that refer to configuration properties and move them to HConstants.

        Activity

        Lars George created issue -
        Harsh J made changes -
        Field Original Value New Value
        Assignee Harsh J [ qwertymaniac ]
        Harsh J made changes -
        Original Estimate 168h [ 604800 ]
        Remaining Estimate 168h [ 604800 ]
        Harsh J made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Harsh J added a comment -

        I'm recording all the strange param names I encounter as I do this at https://gist.github.com/76416a2211ece8edb95a

        Meanwhile, am hoping no more patches get in with config names as strings…

        Show
        Harsh J added a comment - I'm recording all the strange param names I encounter as I do this at https://gist.github.com/76416a2211ece8edb95a Meanwhile, am hoping no more patches get in with config names as strings…
        Hide
        Lars Hofhansl added a comment -

        Big +1.

        I have actually reviewed some recent patches that add config names as string. Sorry I did not point that out as defect.
        Also many people turn to hbase-default.xml, but many (new and old) configs are not in there.

        Show
        Lars Hofhansl added a comment - Big +1. I have actually reviewed some recent patches that add config names as string. Sorry I did not point that out as defect. Also many people turn to hbase-default.xml, but many (new and old) configs are not in there.
        Harsh J logged work - 28/Dec/11 04:15
        • Time Spent:
          2h
           
          <No comment>
        Harsh J made changes -
        Remaining Estimate 168h [ 604800 ] 166h [ 597600 ]
        Time Spent 2h [ 7200 ]
        Worklog Id 12535 [ 12535 ]
        Hide
        Harsh J added a comment -

        So I posted a diff manually at https://reviews.facebook.net/D1047 for review to take off incrementally, but can't seem to link it to the hbase project. Is using arc the only option?

        Show
        Harsh J added a comment - So I posted a diff manually at https://reviews.facebook.net/D1047 for review to take off incrementally, but can't seem to link it to the hbase project. Is using arc the only option?
        Hide
        Phabricator added a comment -

        QwertyManiac requested code review of "HBASE-3274 [jira] Replace all config properties references in code with string constants".
        Reviewers: JIRA

        Fixes for source packages avro to io.

        See HBASE-2721 for details. We have fixed the default values in HBASE-3272 but we should also follow Hadoop to remove all hardcoded strings that refer to configuration properties and move them to HConstants.

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D1053

        AFFECTED FILES
        src/main/java/org/apache/hadoop/hbase/HConstants.java
        src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java
        src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java
        src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java
        src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
        src/main/java/org/apache/hadoop/hbase/client/HTable.java
        src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java
        src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java
        src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java
        src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java
        src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
        src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java
        src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java
        src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
        src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java

        MANAGE HERALD DIFFERENTIAL RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/2199/

        Tip: use the X-Herald-Rules header to filter Herald messages in your client.

        Show
        Phabricator added a comment - QwertyManiac requested code review of " HBASE-3274 [jira] Replace all config properties references in code with string constants". Reviewers: JIRA Fixes for source packages avro to io. See HBASE-2721 for details. We have fixed the default values in HBASE-3272 but we should also follow Hadoop to remove all hardcoded strings that refer to configuration properties and move them to HConstants. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D1053 AFFECTED FILES src/main/java/org/apache/hadoop/hbase/HConstants.java src/main/java/org/apache/hadoop/hbase/catalog/CatalogTracker.java src/main/java/org/apache/hadoop/hbase/client/ClientScanner.java src/main/java/org/apache/hadoop/hbase/client/HBaseAdmin.java src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java src/main/java/org/apache/hadoop/hbase/client/HTable.java src/main/java/org/apache/hadoop/hbase/client/replication/ReplicationAdmin.java src/main/java/org/apache/hadoop/hbase/coprocessor/CoprocessorHost.java src/main/java/org/apache/hadoop/hbase/io/hfile/AbstractHFileWriter.java src/main/java/org/apache/hadoop/hbase/io/hfile/CacheConfig.java src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlockIndex.java src/main/java/org/apache/hadoop/hbase/io/hfile/slab/SlabCache.java src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java src/main/java/org/apache/hadoop/hbase/regionserver/wal/WALCoprocessorHost.java MANAGE HERALD DIFFERENTIAL RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/2199/ Tip: use the X-Herald-Rules header to filter Herald messages in your client.
        Phabricator made changes -
        Attachment HBASE-3274.D1053.1.patch [ 12508777 ]
        Harsh J made changes -
        Labels painful
        Hide
        Andrew Purtell added a comment -

        Stale issue. Reopen if still relevant.

        Show
        Andrew Purtell added a comment - Stale issue. Reopen if still relevant.
        Andrew Purtell made changes -
        Status In Progress [ 3 ] Resolved [ 5 ]
        Assignee Harsh J [ qwertymaniac ]
        Resolution Won't Fix [ 2 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open In Progress In Progress
        398d 2h 13m 1 Harsh J 27/Dec/11 13:10
        In Progress In Progress Resolved Resolved
        894d 8h 31m 1 Andrew Purtell 08/Jun/14 22:41

          People

          • Assignee:
            Unassigned
            Reporter:
            Lars George
          • Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 168h
              168h
              Remaining:
              Time Spent - 2h Remaining Estimate - 166h
              166h
              Logged:
              Time Spent - 2h Remaining Estimate - 166h
              2h

                Development