Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.90.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      From Lars George list up on hbase-dev:

      Hi,
      
      I went through the config values as per the defaults XML file (still
      going through it again now based on what is actually in the code, i.e.
      those not in defaults). Here is what I found:
      
      hbase.master.balancer.period - Only used in hbase-default.xml?
      
      hbase.regions.percheckin, hbase.regions.slop - Some tests still have
      it but not used anywhere else
      
      zookeeper.pause, zookeeper.retries - Never used? Only in hbase-defaults.xml
      
      
      And then there are differences between hardcoded and XML based defaults:
      
      hbase.client.pause - XML: 1000, hardcoded: 2000 (HBaseClient) and 30 *
      1000 (HBaseAdmin)
      
      hbase.client.retries.number - XML: 10, hardcoded 5 (HBaseAdmin) and 2 (HMaster)
      
      hbase.hstore.blockingStoreFiles - XML: 7, hardcoded: -1
      
      hbase.hstore.compactionThreshold - XML: 3, hardcoded: 2
      
      hbase.regionserver.global.memstore.lowerLimit - XML: 0.35, hardcoded: 0.25
      
      hbase.regionserver.handler.count - XML: 25, hardcoded: 10
      
      hbase.regionserver.msginterval - XML: 3000, hardcoded: 1000
      
      hbase.rest.port - XML: 8080, hardcoded: 9090
      
      hfile.block.cache.size - XML: 0.2, hardcoded: 0.0
      
      
      Finally, some keys are already in HConstants, some are in local
      classes and others used as literals. There is an issue open to fix
      this though. Just saying.
      
      Thoughts?
      

        Activity

        Hide
        Lars George added a comment -

        This is a "dupe" to HBASE-2721. Closing it out as well.

        Show
        Lars George added a comment - This is a "dupe" to HBASE-2721 . Closing it out as well.
        Hide
        stack added a comment -

        Committed to branch and trunk.

        Show
        stack added a comment - Committed to branch and trunk.
        Hide
        stack added a comment -

        Sure.

        Should we up the default zk timeout while we're at it?

        Show
        stack added a comment - Sure. Should we up the default zk timeout while we're at it?
        Hide
        Jean-Daniel Cryans added a comment -

        +1

        Looking at the patch, it made me remember that we wanted to raise the default for blocking store file to something like 12. Do we still want to do this?

        Show
        Jean-Daniel Cryans added a comment - +1 Looking at the patch, it made me remember that we wanted to raise the default for blocking store file to something like 12. Do we still want to do this?
        Hide
        stack added a comment -

        Looking for a +1.

        Show
        stack added a comment - Looking for a +1.
        Hide
        stack added a comment -

        Thanks for making the list Lars. Here is a patch to address your list of issues. It doesn't address your last point. Just removes unused stuff and makes XML match hardcodings. The former I think is an important purge to do for 0.90. The rest not so important but did it anyway.

        Show
        stack added a comment - Thanks for making the list Lars. Here is a patch to address your list of issues. It doesn't address your last point. Just removes unused stuff and makes XML match hardcodings. The former I think is an important purge to do for 0.90. The rest not so important but did it anyway.

          People

          • Assignee:
            stack
            Reporter:
            stack
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development