[HBASE-319] [hbase] Some minor improvements to changes in HADOOP-2443

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Assignee: Unassigned
• Reporter: Bryan Duxbury
• Created: 14/Jan/08 18:06
• Updated: 22/Aug/08 21:34
• Resolved: 02/Feb/08 00:53

Description

Stack made a number of suggestions for improvements in the code changes from HADOOP-2443:

Here in HConnectionManager:

+ scannerId = server.openScanner(
+ metaLocation.getRegionInfo().getRegionName(),
+ COLUMN_FAMILY_ARRAY, EMPTY_START_ROW, LATEST_TIMESTAMP,
+ null);

... EMPTY_START_ROW will work but 'startRow' would be easier to read (It'd work too - right?).

Here:

+ } while (startRow.compareTo(EMPTY_START_ROW) != 0);

.. EMPTY_ROW or a new define, LAST_ROW, would have been more readable, don't you think?

This 999... 'trick' should be done as a method - in HTableInfo? - since you do it twice:

+ Text tableKey = new Text(tableName.toString() + ",,99999999999999");

Issue Links

• incorporates: HBASE-81 [hbase] When a scanner lease times out, throw a more "user friendly" exception