Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-317

Replacing thread notification-based queue with java.util.concurrent.BlockingQueue in HMaster

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      In HMaster, there is a msgQueue typed as an ArrayList<PendingOperations>. PendingOperations are added to the queue and notify() is called on msgQueue. I think using a BlockingQueue<PendingOperations> makes the intent of the code more clear and removes potentially problematic synchronization issues. BlockingQueues are thread-safe and allow multiple producers and consumers. I have written a patch for this and will attach it.

        Attachments

        1. patch.txt
          8 kB
          Jim Kellerman
        2. patch.txt
          8 kB
          Jim Kellerman
        3. HADOOP-1615.patch
          6 kB
          Steve Jenson

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              stevej Steve Jenson
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: