HBase
  1. HBase
  2. HBASE-2924

TestLogRolling doesn't use the right HLog half the time

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.90.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Since HBASE-2868, TestLogRolling uses 2 region servers instead of 1. The rest of the un-refactored code isn't expecting that, and only used the log from the first RS. This is why we get very inconsistent results. Fix by either coming back to 1 RS or at least use the right HLog.

      1. HBASE-2924.patch
        5 kB
        Jean-Daniel Cryans

        Activity

        Hide
        Jean-Daniel Cryans added a comment -

        Patch that adds a new utility method to HBaseTestingUtility to get the region server that holds the first region in a table, which is used to select the right server in TestLogRolling. Test now passes 100% of the time (on 8 runs).

        Show
        Jean-Daniel Cryans added a comment - Patch that adds a new utility method to HBaseTestingUtility to get the region server that holds the first region in a table, which is used to select the right server in TestLogRolling. Test now passes 100% of the time (on 8 runs).
        Hide
        Lars Francke added a comment -

        Applied the patch, ran the test five times. Everything looks fine now. Thanks for finding and fixing this!

        +1

        Show
        Lars Francke added a comment - Applied the patch, ran the test five times. Everything looks fine now. Thanks for finding and fixing this! +1
        Hide
        stack added a comment -

        +1 though I do not like your addition to HBaseTestingUtiliy. My guess is that this test is only test that will use the added method. We shoudl be a little judicious about what we add HTU. We don't want it to be turn into a hard to maintain dumping ground.

        Show
        stack added a comment - +1 though I do not like your addition to HBaseTestingUtiliy. My guess is that this test is only test that will use the added method. We shoudl be a little judicious about what we add HTU. We don't want it to be turn into a hard to maintain dumping ground.
        Hide
        Jean-Daniel Cryans added a comment -

        I refactored TestScannerTimeout to use the new tool too, which is now more commented. Committed to trunk.

        Show
        Jean-Daniel Cryans added a comment - I refactored TestScannerTimeout to use the new tool too, which is now more commented. Committed to trunk.

          People

          • Assignee:
            Jean-Daniel Cryans
            Reporter:
            Jean-Daniel Cryans
          • Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development