Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.90.0
    • Component/s: regionserver
    • Labels:
      None

      Description

      When a rowcol Bloom filter is being used and the user submits a query for all columns, a null pointer exception is thrown. This is because there is no checking if columns have been specified or not.

        Activity

        Hide
        HBase Review Board added a comment -

        Message from: "Pranav Khaitan" <pranavkhaitan@facebook.com>

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        http://review.hbase.org/r/336/
        -----------------------------------------------------------

        Review request for hbase, Nicolas, Karthik Ranganathan, and Kannan Muthukkaruppan.

        Summary
        -------

        Fixed bloom filter code in StoreFile

        This addresses bug HBASE-2852.
        http://issues.apache.org/jira/browse/HBASE-2852

        Diffs


        trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 965615
        trunk/src/test/java/org/apache/hadoop/hbase/client/TestBloomFilter.java PRE-CREATION

        Diff: http://review.hbase.org/r/336/diff

        Testing
        -------

        JUnit tests added

        Thanks,

        Pranav

        Show
        HBase Review Board added a comment - Message from: "Pranav Khaitan" <pranavkhaitan@facebook.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/336/ ----------------------------------------------------------- Review request for hbase, Nicolas, Karthik Ranganathan, and Kannan Muthukkaruppan. Summary ------- Fixed bloom filter code in StoreFile This addresses bug HBASE-2852 . http://issues.apache.org/jira/browse/HBASE-2852 Diffs trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 965615 trunk/src/test/java/org/apache/hadoop/hbase/client/TestBloomFilter.java PRE-CREATION Diff: http://review.hbase.org/r/336/diff Testing ------- JUnit tests added Thanks, Pranav
        Hide
        HBase Review Board added a comment -

        Message from: "Ryan Rawson" <ryanobjc@gmail.com>

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        http://review.hbase.org/r/336/#review425
        -----------------------------------------------------------

        trunk/src/test/java/org/apache/hadoop/hbase/client/TestBloomFilter.java
        <http://review.hbase.org/r/336/#comment1794>

        can you rework this test not to use TEST_UTIL and starting up a mini-hbase cluster?

        For alternate options, try doing what HRegion does, which is to instantiate a HRegion then use the HRegion API calls instead.

        • Ryan
        Show
        HBase Review Board added a comment - Message from: "Ryan Rawson" <ryanobjc@gmail.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/336/#review425 ----------------------------------------------------------- trunk/src/test/java/org/apache/hadoop/hbase/client/TestBloomFilter.java < http://review.hbase.org/r/336/#comment1794 > can you rework this test not to use TEST_UTIL and starting up a mini-hbase cluster? For alternate options, try doing what HRegion does, which is to instantiate a HRegion then use the HRegion API calls instead. Ryan
        Hide
        HBase Review Board added a comment -

        Message from: "Pranav Khaitan" <pranavkhaitan@facebook.com>

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        http://review.hbase.org/r/336/
        -----------------------------------------------------------

        (Updated 2010-07-20 11:19:26.615795)

        Review request for hbase, Nicolas, Karthik Ranganathan, and Kannan Muthukkaruppan.

        Changes
        -------

        Moved the test to TestHRegion

        Summary
        -------

        Fixed bloom filter code in StoreFile

        This addresses bug HBASE-2852.
        http://issues.apache.org/jira/browse/HBASE-2852

        Diffs (updated)


        trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 965615
        trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 965615

        Diff: http://review.hbase.org/r/336/diff

        Testing
        -------

        JUnit tests added

        Thanks,

        Pranav

        Show
        HBase Review Board added a comment - Message from: "Pranav Khaitan" <pranavkhaitan@facebook.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/336/ ----------------------------------------------------------- (Updated 2010-07-20 11:19:26.615795) Review request for hbase, Nicolas, Karthik Ranganathan, and Kannan Muthukkaruppan. Changes ------- Moved the test to TestHRegion Summary ------- Fixed bloom filter code in StoreFile This addresses bug HBASE-2852 . http://issues.apache.org/jira/browse/HBASE-2852 Diffs (updated) trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 965615 trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 965615 Diff: http://review.hbase.org/r/336/diff Testing ------- JUnit tests added Thanks, Pranav
        Hide
        HBase Review Board added a comment -

        Message from: "Ryan Rawson" <ryanobjc@gmail.com>

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        http://review.hbase.org/r/336/#review445
        -----------------------------------------------------------

        trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        <http://review.hbase.org/r/336/#comment1872>

        you should use initHRegion in this class instead of repeating the boilerplate.

        trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
        <http://review.hbase.org/r/336/#comment1871>

        this might not be necessary, since flushcache() returns after the file has been loaded into HRegion/Stores.

        • Ryan
        Show
        HBase Review Board added a comment - Message from: "Ryan Rawson" <ryanobjc@gmail.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/336/#review445 ----------------------------------------------------------- trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java < http://review.hbase.org/r/336/#comment1872 > you should use initHRegion in this class instead of repeating the boilerplate. trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java < http://review.hbase.org/r/336/#comment1871 > this might not be necessary, since flushcache() returns after the file has been loaded into HRegion/Stores. Ryan
        Hide
        HBase Review Board added a comment -

        Message from: "Pranav Khaitan" <pranavkhaitan@facebook.com>

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        http://review.hbase.org/r/336/
        -----------------------------------------------------------

        (Updated 2010-07-21 23:04:10.126963)

        Review request for hbase, Nicolas, Karthik Ranganathan, and Kannan Muthukkaruppan.

        Summary
        -------

        Fixed bloom filter code in StoreFile

        This addresses bug HBASE-2852.
        http://issues.apache.org/jira/browse/HBASE-2852

        Diffs (updated)


        trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 965615
        trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 965615

        Diff: http://review.hbase.org/r/336/diff

        Testing
        -------

        JUnit tests added

        Thanks,

        Pranav

        Show
        HBase Review Board added a comment - Message from: "Pranav Khaitan" <pranavkhaitan@facebook.com> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/336/ ----------------------------------------------------------- (Updated 2010-07-21 23:04:10.126963) Review request for hbase, Nicolas, Karthik Ranganathan, and Kannan Muthukkaruppan. Summary ------- Fixed bloom filter code in StoreFile This addresses bug HBASE-2852 . http://issues.apache.org/jira/browse/HBASE-2852 Diffs (updated) trunk/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFile.java 965615 trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java 965615 Diff: http://review.hbase.org/r/336/diff Testing ------- JUnit tests added Thanks, Pranav
        Hide
        Pranav Khaitan added a comment -

        Thanks for going through the patch. I had updated the patch based on the
        latest suggestions. Please let me know if any further changes are required.

        Regards,
        Pranav

        Show
        Pranav Khaitan added a comment - Thanks for going through the patch. I had updated the patch based on the latest suggestions. Please let me know if any further changes are required. Regards, Pranav
        Hide
        Jonathan Gray added a comment -

        Final patch from pranav over on reviewboard to be committed

        Show
        Jonathan Gray added a comment - Final patch from pranav over on reviewboard to be committed
        Hide
        HBase Review Board added a comment -

        Message from: "Jonathan Gray" <jgray@apache.org>

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        http://review.hbase.org/r/336/#review492
        -----------------------------------------------------------

        Ship it!

        Just a simple null check and added test. LGTM

        • Jonathan
        Show
        HBase Review Board added a comment - Message from: "Jonathan Gray" <jgray@apache.org> ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/336/#review492 ----------------------------------------------------------- Ship it! Just a simple null check and added test. LGTM Jonathan
        Hide
        Jonathan Gray added a comment -

        Committed to trunk. Thanks pranav.

        Show
        Jonathan Gray added a comment - Committed to trunk. Thanks pranav.
        Hide
        HBase Review Board added a comment -

        Message from: "Jonathan Gray" <jgray@apache.org>

        On 2010-07-26 18:25:37, Jonathan Gray wrote:

        > Just a simple null check and added test. LGTM

        and all of ryan's comments have been addressed. thanks pranav.

        • Jonathan

        -----------------------------------------------------------
        This is an automatically generated e-mail. To reply, visit:
        http://review.hbase.org/r/336/#review492
        -----------------------------------------------------------

        Show
        HBase Review Board added a comment - Message from: "Jonathan Gray" <jgray@apache.org> On 2010-07-26 18:25:37, Jonathan Gray wrote: > Just a simple null check and added test. LGTM and all of ryan's comments have been addressed. thanks pranav. Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://review.hbase.org/r/336/#review492 -----------------------------------------------------------

          People

          • Assignee:
            Pranav Khaitan
            Reporter:
            Pranav Khaitan
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development