Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 0.90.0
    • Fix Version/s: None
    • Component/s: Thrift
    • Labels:
      None

      Description

      Hello, i have create small patch for thrift interface to increament many columns in many rows in many tables, but im not a hbase or even java developer so if someone want to look at this and create somethink better i would be appreciate.

      thanks
      S.Bauer

      PS. sorry for my bad english

      1. hbase.patch
        44 kB
        Sebastian Bauer
      2. hbase.patch
        44 kB
        Sebastian Bauer
      3. hbase.patch
        44 kB
        Sebastian Bauer

        Issue Links

          Activity

          Hide
          Sebastian Bauer added a comment -

          rename IncreamentMutation as IncrementMutation

          Show
          Sebastian Bauer added a comment - rename IncreamentMutation as IncrementMutation
          Hide
          stack added a comment -

          Hey Sebastian:

          Patch looks good. Does it work for you?

          FYI, we do 80 characters a line but, looks like the > 80 character lines are generated, is that right? So the patch includes the thrift generated code it seems?

          Is this comment right? It doesn't seem to apply to IncrementMutation, your new class: + * A Mutation object is used to either update or delete a column-value.

          Show
          stack added a comment - Hey Sebastian: Patch looks good. Does it work for you? FYI, we do 80 characters a line but, looks like the > 80 character lines are generated, is that right? So the patch includes the thrift generated code it seems? Is this comment right? It doesn't seem to apply to IncrementMutation, your new class: + * A Mutation object is used to either update or delete a column-value.
          Hide
          Sebastian Bauer added a comment -

          small changes in comments

          Show
          Sebastian Bauer added a comment - small changes in comments
          Hide
          Sebastian Bauer added a comment -

          It was my mistake when i copy Mutation class. About intendation and code style i dont now how to setup eclipse properly because when i change line width to 80 and make auto format when many other lines will change

          Show
          Sebastian Bauer added a comment - It was my mistake when i copy Mutation class. About intendation and code style i dont now how to setup eclipse properly because when i change line width to 80 and make auto format when many other lines will change
          Hide
          stack added a comment -

          I can format for you (If generated classes are > 80 chars, thats not a problem). Does this patch work for you?

          Show
          stack added a comment - I can format for you (If generated classes are > 80 chars, thats not a problem). Does this patch work for you?
          Hide
          Sebastian Bauer added a comment -

          I'm sure that lines ar >80 chars and yes this patch is working and i'm using it for about week.

          Show
          Sebastian Bauer added a comment - I'm sure that lines ar >80 chars and yes this patch is working and i'm using it for about week.
          Hide
          stack added a comment -

          @Sebastian One other question... one version of thrift did you use generating classes? Was it thrift 0.2.0?

          Show
          stack added a comment - @Sebastian One other question... one version of thrift did you use generating classes? Was it thrift 0.2.0?
          Hide
          Sebastian Bauer added a comment -

          I didn't use thrift, couse i don't know how to do this.

          If you mean this files:
          thrift/generated/IncrementMutation.java
          thrift/generated/Hbase.java

          i made this changes by modifying other code

          Show
          Sebastian Bauer added a comment - I didn't use thrift, couse i don't know how to do this. If you mean this files: thrift/generated/IncrementMutation.java thrift/generated/Hbase.java i made this changes by modifying other code
          Hide
          stack added a comment -

          @Sebastien Your patch includes changes to classes that are usually generated by thrift. How were these generated class changes made?

          See here http://hbase.apache.org/docs/r0.20.5/api/org/apache/hadoop/hbase/thrift/package-summary.html#package_description for a few notes on using thrift to generate code. Its important that you use the right version of thrift, the one that is bundled with hbase at least.

          Show
          stack added a comment - @Sebastien Your patch includes changes to classes that are usually generated by thrift. How were these generated class changes made? See here http://hbase.apache.org/docs/r0.20.5/api/org/apache/hadoop/hbase/thrift/package-summary.html#package_description for a few notes on using thrift to generate code. Its important that you use the right version of thrift, the one that is bundled with hbase at least.
          Hide
          Sebastian Bauer added a comment -

          after generate files by thrift -strict --gen java Hbase.thrift classes are without licence header, hashCode functions and with intendation errors, so i think this patch is better, its working with classes generated with thrift 0.2.0 for python
          you can try regenerate classes in src/main/java/org/apache/hadoop/hbase/thrift/generated with thrift and you can see how it look

          Show
          Sebastian Bauer added a comment - after generate files by thrift -strict --gen java Hbase.thrift classes are without licence header, hashCode functions and with intendation errors, so i think this patch is better, its working with classes generated with thrift 0.2.0 for python you can try regenerate classes in src/main/java/org/apache/hadoop/hbase/thrift/generated with thrift and you can see how it look
          Hide
          stack added a comment -

          So, you are editing the generated files by hand?

          Show
          stack added a comment - So, you are editing the generated files by hand?
          Hide
          Sebastian Bauer added a comment -

          yes

          Show
          Sebastian Bauer added a comment - yes
          Hide
          stack added a comment -

          You should not be editing anything under the 'generated' package by hand. Please use thrift to generate these classes as per the above cited link. Thanks.

          Show
          stack added a comment - You should not be editing anything under the 'generated' package by hand. Please use thrift to generate these classes as per the above cited link. Thanks.
          Hide
          Andrew Purtell added a comment -

          (Partial) dup of HBASE-2947?

          Show
          Andrew Purtell added a comment - (Partial) dup of HBASE-2947 ?
          Hide
          Andrew Purtell added a comment -

          Stale issue. Reopen if still relevant (if there's new activity)

          Show
          Andrew Purtell added a comment - Stale issue. Reopen if still relevant (if there's new activity)

            People

            • Assignee:
              Unassigned
              Reporter:
              Sebastian Bauer
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development