Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-27503

Support replace <FILE-PATH> in GC_OPTS for ZGC

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 2.4.15
    • 2.6.0, 3.0.0-alpha-4, 2.4.16, 2.5.3
    • scripts
    • None
    • Reviewed

    Description

      HBase support replace -Xloggc:<FILE-PATH> for G1 or CMS。ZGC changed the format,like this:

      -Xlog:safepoint,classhisto*=trace,age*,gc*=info:file=<FILE-PATH>:time,tid,tags:filecount=1,filesize=500M

      Can  we only replace <FILE-PATH> instead of -Xloggc:<FILE-PATH> to support ZGC?

      https://github.com/apache/hbase/blob/master/bin/hbase-daemon.sh#L174

      if [ -n "$SERVER_GC_OPTS" ]; then  
        export SERVER_GC_OPTS=${SERVER_GC_OPTS/"-Xloggc:<FILE-PATH>"/"-Xloggc:${HBASE_LOGGC}"}
      fi
      if [ -n "$CLIENT_GC_OPTS" ]; then  
        export CLIENT_GC_OPTS=${CLIENT_GC_OPTS/"-Xloggc:<FILE-PATH>"/"-Xloggc:${HBASE_LOGGC}"}
      fi 

      Attachments

        Issue Links

          Activity

            People

              mrzhao Moran
              mrzhao Moran
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: