Uploaded image for project: 'HBase'
  1. HBase
  2. HBASE-27222

Purge FutureReturnValueIgnored warnings from error prone

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.5.0, 3.0.0-alpha-4
    • netty
    • None
    • Reviewed

    Description

      We used to introduce a FutureUtils to purge the FutureReturnValueIgnored warnings in the async client implementation, to make sure we catch the exception from the callback.

      For netty, we could apply the same trick. And there is another problem for netty that channel.write and some other methods will also return a ChannelFuture but usually we just do nothing on it, this will generated a FutureReturnValueIgnored warning too. We could add a logging listener to log the errors if any.

      Attachments

        Issue Links

          Activity

            People

              zhangduo Duo Zhang
              zhangduo Duo Zhang
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: