[HBASE-27030] Fix undefined local variable error in draining_servers.rb

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha-3
• Fix Version/s: 2.5.0, 3.0.0-alpha-3, 2.4.13
• Component/s: jruby, shell
• Hadoop Flags: Reviewed
• Assignee: Junegunn Choi
• Reporter: Junegunn Choi
• Created: 13/May/22 08:41
• Updated: 23/May/22 05:39
• Resolved: 22/May/22 07:08

Description

HBASE-21812 replaced a for-loop with an each block. Each block introduces a new scope, so a local variable defined inside it cannot be accessed afterwards.

  NameError: undefined local variable or method `admin' for main:Object
    getServerNames at /opt/khp/hbase/bin/draining_servers.rb:81
        addServers at /opt/khp/hbase/bin/draining_servers.rb:88
            <main> at /opt/khp/hbase/bin/draining_servers.rb:146

 

for i in [1, 2, 3]
  a = i
end
puts a
  # 3

[4, 5, 6].each do |i|
  b = i
end
puts b
  # undefined local variable or method `b'

We can define the admin local variable in the current scope beforehand, and we can still access it after the block.

 

Issue Links

• links to: GitHub Pull Request #4427