[HBASE-26773] [hbase-thirdparty] Introduce a hbase-unsafe module in hbase-thirdparty to remove the direct references of Unsafe in our main code base

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: thirdparty-4.1.0
• Component/s: compatibility, thirdparty
• Hadoop Flags: Reviewed
• Release Note: Introduced a new hbase-unsafe module in hbase-thirdparty.
• Assignee: Duo Zhang
• Reporter: Duo Zhang
• Created: 26/Feb/22 03:28
• Updated: 28/Feb/24 08:15
• Resolved: 01/Mar/22 13:30

Description

For java 9+, sun.misc.Unsafe is in the module jdk.unsupported. When compiling with java 11 --release 8, these symbols will not be exported and lead to compile errors.

There is a jdk issue

https://bugs.openjdk.java.net/browse/JDK-8214165

But seems the jdk team does not want to fix it. So if we want to move up to java 11 but still keep the java 8 compatibility, a possible choice is to remove the direct reference of sun.misc.Unsafe so at compile time there will be no problem, and at runtime we export the jdk.unsupported so there will be no problem too.

For more details, please see the discussion of this thread on the dev mailing list.

https://lists.apache.org/thread/w5lrxkhswlonj09xf9hcwgvck3nsjdfx

Issue Links

• blocks: HBASE-25465 Use javac --release option for supporting cross version compilation
• is related to: HBASE-28380 Build hbase-thirdparty with JDK17
• relates to: PHOENIX-7037 Use or clone hbase-unsafe in Phoenix
• links to: GitHub Pull Request #78