[HBASE-26745] MetricsStochasticBalancerSource metrics don't render in /jmx endpoint

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.5.0, 3.0.0-alpha-3, 2.4.11
• Labels: patch-available
• Hadoop Flags: Reviewed
• Assignee: Briana Augenreich
• Reporter: Bryan Beaudreault
• Created: 08/Feb/22 16:29
• Updated: 01/Sep/22 10:57
• Resolved: 03/Mar/22 01:49

Description

The check in JSONBean here causes the balancer cost metrics to be excluded from the /jmx endpoint. I think we should just remove the check for ":". I don't think including metrics with a colon in them poses any problem, since the strings are quoted. We removed this check in our cdh5 fork almost a year ago and have not seen any issues.

Alternatively we can fix the MetricsStochasticBalancerSource metrics to emit metrics that adhere to these filters, but I think that would be a backwards incompatible change since this is only a json rendering issue and people might be consuming JMX directly.

Issue Links

• links to: GitHub Pull Request #4140