[HBASE-26613] The logic of the method incrementIV in Encryption class has problem

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.5.0, 3.0.0-alpha-3, 2.4.10
• Component/s: Performance, security
• Hadoop Flags: Reviewed
• Assignee: Yutong Xiao
• Reporter: Yutong Xiao
• Created: 21/Dec/21 01:53
• Updated: 28/Dec/21 15:51
• Resolved: 22/Dec/21 16:17

Description

public static void incrementIv(byte[] iv, int v) {
    int length = iv.length;
    boolean carry = true;
    // TODO: Optimize for v > 1, e.g. 16, 32
    do {
      for (int i = 0; i < length; i++) {
        if (carry) {
          iv[i] = (byte) ((iv[i] + 1) & 0xFF);
          carry = 0 == iv[i];
        } else {
          break;
        }
      }
      v--;
    } while (v > 0);
  }

The carry flag is outside the while loop and the inner loop check the carry value is true, so that when it was set to false, it will make the rest iterations busy spinning.
And the logic becomes whatever the v is, the IV will be incremented by (1 or 2). As the description in todo, this function should support increment value > 1. So that this is not what we expect I think.

Issue Links

• relates to: HBASE-26619 Backport HBASE-26613 to branch-1
• links to: GitHub Pull Request #3968