[HBASE-26582] Prune use of Random and SecureRandom objects

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 2.5.0, 3.0.0-alpha-3, 2.4.11
• Hadoop Flags: Reviewed
• Assignee: Andrew Kyle Purtell
• Reporter: Andrew Kyle Purtell
• Created: 15/Dec/21 18:24
• Updated: 01/Sep/22 10:57
• Resolved: 09/Mar/22 01:42

Description

While looking over Findbugs/Spotbugs findings on HBASE-26555 I noticed we have some violations of Spotbugs rules regarding lack of Random object re-use, and generally have a lot of static Random and SecureRandom objects in our code, especially in tests, where ThreadLocalRandom would be more than sufficient.

This is nitty stuff but let's clean it up. It will reduce noise on the analysis reports and SecureRandom is unnecessarily slow when used wherever we don't need it.

Issue Links

• links to: GitHub Pull Request #4118